Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[live demo] dropdown bugs #1987

Closed
22 tasks
laurenmrice opened this issue Nov 16, 2020 · 1 comment
Closed
22 tasks

[live demo] dropdown bugs #1987

laurenmrice opened this issue Nov 16, 2020 · 1 comment

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Nov 16, 2020

The live demo for dropdown has the followings bugs:


Dropdown

  • missing inline variant prop
  • missing different size variants
  • missing direction prop to open bottom/top
  • missing warning state prop
  • missing invalid state prop
  • When the light prop is applied it is not showing the latest updates of the color changes we made with hover-light-ui token.
  • The dropdown size changes in width depending on the text length of the option you select from the menu. The dropdown should maintain the same width no matter how long the option text entry is.
    Nov-16-2020 13-42-23

Combo box

  • missing inline variant prop
  • missing different size variants
  • missing direction prop to open bottom/top
  • missing warning state prop
  • missing invalid state prop
  • the close icon should be icon-01
  • The field of combobox is showing up empty. The prompt text "Filter..." needs to be shown in the field asbody-short-01 and text-03.

Screen Shot 2020-11-16 at 3 25 01 PM

- [ ] The text sits too high and is not sitting in the center vertically within the field.

Screen Shot 2020-11-16 at 3 28 02 PM


Multi-select/Filterable Multi-select

  • missing inline variant prop
  • missing different size variants
  • missing the direction prop to open bottom/top
  • missing warning state prop
  • missing invalid state prop
  • The option text in the open menu needs to be text-02 not text-01 by default. It changes to text-01 on hover or when selected.
  • The number in the tag sits too high. It needs to be center within the tag container.
  • the close icon should be icon-01 for the filterable multi-select.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants