Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dropdown] update style images #1997

Closed
13 tasks done
laurenmrice opened this issue Nov 19, 2020 · 0 comments · Fixed by #2103
Closed
13 tasks done

[dropdown] update style images #1997

laurenmrice opened this issue Nov 19, 2020 · 0 comments · Fixed by #2103
Assignees
@aagonzales
Labels
component: combobox component: dropdown component: multiselect type: bug 🐛 type: docs 📖

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Nov 19, 2020 •
edited by aagonzales
Loading

Dropdown

  • Update closed and open image
  • Add states image
  • Update dropdown spec image

Multiselect

  • Update spec image

Combobox

  • Should there be a section for this?

Inline

  • Update spec image
  • Update state image

Filtering

  • Maybe address this section as “Combobox” instead?
  • Update spec image
  • Update state image or omit image

Also add these code lines to style tables

  • Add disabled color for chevron icon to interactive table
  • Add invalid color and inner fill color for svg
  • Add warning color and inner fill color for warning icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aagonzales aagonzales

Labels
component: combobox component: dropdown component: multiselect type: bug 🐛 type: docs 📖
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(dropdown): audit style
docs(dropdown): audit udpates
2 participants
@aagonzales @laurenmrice