Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11: update style tabs with new tokens #2257

Closed
31 tasks done
aagonzales opened this issue Apr 29, 2021 · 3 comments
Closed
31 tasks done

v11: update style tabs with new tokens #2257

aagonzales opened this issue Apr 29, 2021 · 3 comments

Comments

@aagonzales
Copy link
Member

aagonzales commented Apr 29, 2021

Primary task

Update all component style tab pages in the v11 branch to have the new token names. See Notion doc for full list. Some component specs with v11 tokens are available in this other issue or just reference the notion doc for old -> new tokens migration.

image

Updates will be made in markdown in the ## Color section of the style tab.
image

Optional image updates
Also is if any one feels inclined to update in out date style tabs in there while you're at it you get super brownie points with me! (not required though but please at least make a note of in correct images)

Thy

  • Accordion
  • Breadcrumb
  • Button
  • Checkbox
  • Code snippet
  • Content switcher

Lauren

John

Tracey

Anna

@aagonzales
Copy link
Member Author

aagonzales commented May 17, 2021

Updates can either be made through your local build or you can makes these updates through the GitHub web app by going to "Edit this page on Github" link at the bottom of each page.

  1. Go to the page and tab you want to edit. Scroll to the bottom and click on the "Edit this page on Github" link.
    image

  2. In the url change main to v11
    image

  3. Edit markdown file with update content
    image

  4. After you make all your edits scroll to the bottom of the page and select "create new branch" then hit the commit changes button
    image

  5. Change base from main to v11 then create your pull request.
    image

@thyhmdo
Copy link
Member

thyhmdo commented May 18, 2021

Adding Jan's example here to make it easier for reviewers when creating PRs for v11

Title
docs: v11 color token updates for accordion component

Description
This PR updates the color tokens on the Style tab for the accordion component.

@laurenmrice
Copy link
Member

laurenmrice commented May 18, 2021

Embedded components

  • Link out to the style guidance for that specific component inside of the table.
  • Ref data table style tab:

Screen Shot 2021-05-19 at 9 30 47 PM


Specifying an inline theme

  • Use $[token]: inline theme when inline theming is required for a part of the component by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants