Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured list Live demo does not match storybook #3632

Closed
mbgower opened this issue Jul 7, 2023 · 1 comment · Fixed by #3641
Closed

Structured list Live demo does not match storybook #3632

mbgower opened this issue Jul 7, 2023 · 1 comment · Fixed by #3641

Comments

@mbgower
Copy link
Contributor

mbgower commented Jul 7, 2023

This is a new issue with structured list beyond that flagged in the discussion on the row indicator icon and positioning.

In the live demo version of selectable structured list on the Usage page of the carbondesignsystem.com site, the table header takes focus. What is the rationale for this? It's not sortable. It's obviously not selectable. Seems like an error

Also, each of the rows is in the tab order (twice), which I think doesn't follow the documented interaction, since this is basically a radio button group. Obviously even if it WAS supposed to navigable by tab, each row should not require two presses of the Tab key

image.png

NOTE: the storybook implementation, neither oddity exists (header not navigable, single tabstop for list, with arrow movement between them)

Steps to reproduce the issue

  1. Open https://carbondesignsystem.com/components/structured-list/usage#live-demo
  2. Change the Variant selector dropdown to "Selectable structured list"
  3. Press Tab to enter the list and continue pressing to verify tab navigation for each row (and that 2 presses is needed to advance)
  4. Shift+Tab to the table column header (top row) and confirm the header row takes focus.
@tay1orjones
Copy link
Member

In the codeblock for this, there's a hardcoded tabIndex that needs to be removed. Not sure why that was added there in the livedemo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants