fix: overflow menu bg color on color tokens page #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
requested review from
laurenmrice
and removed request for
kingtraceyj
There was a problem hiding this comment.
Overflow menu bg color LGTM, though I still see the tooltip issue, is there a separate issue/pr for that @alisonjoseph ?
|
@francinelucca I forgot to commit that file, should be updated now. |
francinelucca
requested changes
Jul 13, 2023
|
@francinelucca Oh weird, I didn't even notice its shifted a few px to the left. |
tw15egan
approved these changes
Jul 14, 2023
laurenmrice
approved these changes
Jul 14, 2023
francinelucca
approved these changes
Jul 14, 2023
francinelucca
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3637
Changelog
https://carbondesignsystem-git-fork-alisonj-0f81a7-carbon-design-system.vercel.app/guidelines/color/tokens