Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contained list considerations #3677

Open
mbgower opened this issue Aug 3, 2023 · 0 comments
Open

Contained list considerations #3677

mbgower opened this issue Aug 3, 2023 · 0 comments

Comments

@mbgower
Copy link
Contributor

mbgower commented Aug 3, 2023

This is a summary of key considerations for the contained list documentation. A more detailed list of considerations based on the existing guidance is covered in the comments for the usage.pdf and style.pdf.

  • there is no persistent visual affordance showing when a contained list is clickable
  • it is unclear what the purpose/value is of the enumeration number
  • what is the point of filtering on a contained list?
  • the interaction of the "add" list function needs to be clarified

Each is described in more detail below.

Note: this issue is additional to specific implementation issues with contained list, which are captured in the following:
carbon-design-system/carbon#14172
carbon-design-system/carbon#13943
carbon-design-system/carbon#14174


No persistent visual indicator of clickable list items

The Interactive Items version takes keyboard focus on each item, but it is unclear what exactly happens if I activate.

Probably more critically, there is no visual difference between the interactive and non-interactive contained list, until I interact with them. Why is there no visual cue? Something that communicated to the user both that it is clickable, and what the likely result of clicking will be would be useful.

Screenshot 2023-07-06 at 2.27.34 PM.png
image.png

Purpose of enumeration?

Unless the lists are collapsible (which I am in no way advocating for), the enumeration on the list title in List Title Decorators seems superfluous.
What is the business need/use case for this?

Screenshot 2023-07-06 at 2.34.38 PM.png

Need for filtering?

I would like to better understand the intended usage of the persistent search and expandable search. Are these lists expected to get into the tens and hundreds of items?
Is that really a good use case for a persistent list? Isn't that more of a dropdown function?

Add list function could use documentation

There are a few considerations for the Add list function.
First, on storybook, it is called "Usage example", which really does not convey what it's about.
https://react.carbondesignsystem.com/?path=/story/components-containedlist--usage-examples#storybook-preview-wrapper
Second, it's not clear how the add button works: what it's called, how values for the new list item are added and validated, where the new item appears, etc

Screenshot 2023-08-03 at 1 18 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

3 participants