Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contained list accessibility.mdx #3685

Merged
merged 18 commits into from
Aug 28, 2023

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Aug 4, 2023

First draft of new accessibility content (without images)

First draft of new accessibility content (without images)
@vercel
Copy link

vercel bot commented Aug 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:49pm

Updated the info for the design annotation image set
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need help with images for this PR.

@laurenmrice laurenmrice self-requested a review August 23, 2023 17:38
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's up with the preview but the images look good locally.

image

@mbgower mbgower changed the title Update accessibility.mdx Update contained list accessibility.mdx Aug 24, 2023
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have revised the images in the image box folder

src/pages/components/contained-list/accessibility.mdx Outdated Show resolved Hide resolved
@laurenmrice laurenmrice self-requested a review August 24, 2023 20:51
Used Lauren's version
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
@mbgower
Copy link
Contributor Author

mbgower commented Aug 25, 2023

@laurenmrice images and editorial changes incorporated. Please review and approve

@kodiakhq kodiakhq bot merged commit 9702ec4 into main Aug 28, 2023
5 of 6 checks passed
@kodiakhq kodiakhq bot deleted the component-contained-list-accessibility branch August 28, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants