Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Tokens page breaks when switching themes for component tokens #4239

Closed
alisonjoseph opened this issue Sep 5, 2024 · 2 comments · Fixed by #4248
Closed

Color Tokens page breaks when switching themes for component tokens #4239

alisonjoseph opened this issue Sep 5, 2024 · 2 comments · Fixed by #4248
Assignees
Labels
role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@alisonjoseph
Copy link
Member

Tokens page breaks when clicking gray 100 or gray 90 tabs under component tokens.

@preetibansalui preetibansalui self-assigned this Sep 6, 2024
@preetibansalui
Copy link
Contributor

Hi @alisonjoseph,

It looks like the issue is due to missing Gray 90 and Gray 100 values in the notificationActionHover token. We referenced this file, and those values don't appear to be listed there either. Could you or @aagonzales provide the missing values?

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Sep 9, 2024

@preetibansalui

Gray 90 theme
gray 80 hover (#474747)
Gray 100 theme
gray 90 hover (#333333)

We also need an issue/PR to update this in the themes package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants