Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update #4287

Merged
merged 13 commits into from
Oct 10, 2024
Merged

docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update #4287

merged 13 commits into from
Oct 10, 2024
+83 −0

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #3993
Closes #4223
Closes #4226

Short description

This PR updates the component's Usage and Code tabs with the feature flag code changes for Modal, Menu buttons (Overflow menu), and Treeview, including feature flag information and images.

Note: Links pointing to the "Feature Flag tab" are currently non-functional as that page is not live yet.

Changelog

New

Usage:

  • Feature flag tag
  • Content (feature flag section)

Code:

  • Resource card feature flag tag
  • Content (feature flag section)

For ref: Figma file

@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Oct 10, 2024 5:19pm

@Kritvi-bhatia17 Kritvi-bhatia17 marked this pull request as ready for review September 24, 2024 14:29
@Kritvi-bhatia17 Kritvi-bhatia17 changed the title Adding feature flag to Modal, Menu buttons (Overflow menu), Treeview docs(Modal, Menu buttons (Overflow menu), Treeview) Feature flag usage, code tab update Sep 24, 2024
@carbon-design-system carbon-design-system deleted a comment from netlify bot Sep 24, 2024
thyhmdo
thyhmdo reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few suggestions.

src/pages/components/modal/code.mdx Show resolved Hide resolved
src/pages/components/menu-buttons/code.mdx Show resolved Hide resolved
aagonzales
aagonzales approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, just an FYI comment.

src/pages/components/modal/usage.mdx Outdated Show resolved Hide resolved
@Kritvi-bhatia17
Copy link
Contributor Author

Hi @carbon-design-system/developers, could I please get some reviews on this PR? Thank you!

@laurenmrice laurenmrice self-requested a review October 10, 2024 15:57
@alisonjoseph alisonjoseph merged commit 9c4ad91 into carbon-design-system:main Oct 10, 2024
6 of 7 checks passed
@alisonjoseph
Copy link
Member

*confirmed local build before force-merging because Vercel issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
6 participants
@Kritvi-bhatia17 @alisonjoseph @aagonzales @sstrubberg @laurenmrice @thyhmdo