Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon guideline links #919

Closed
tw15egan opened this issue Feb 18, 2020 · 1 comment · Fixed by #1317
Closed

Update icon guideline links #919

tw15egan opened this issue Feb 18, 2020 · 1 comment · Fixed by #1317

Comments

@tw15egan
Copy link
Member

Cross-referencing an issue over on the component repo, some feedback regarding outdated links that led to some confusion over icons

carbon-design-system/carbon#5226 (comment)

**Just a quick follow up on this from the developer as I think the confusion was perhaps related to outdated documentation **

  1. Some links in Guidelines point here (with instructions to create the icons inline and messaging that say's they've been cleaned):

https://github.com/carbon-design-system/carbon-icons/blob/master/docs/usage.md
https://github.com/carbon-design-system/carbon-icons

  1. And some links in https://www.carbondesignsystem.com/get-started/develop/vanilla/#scss
    points here https://github.com/carbon-design-system/carbon-icons

When I think it should link here:
https://github.com/carbon-design-system/carbon/tree/master/packages/icons
Or here:
https://www.npmjs.com/package/@carbon/icons

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants