Skip to content

Commit

Permalink
fix(structured-list): fix DAP errors (#5066)
Browse files Browse the repository at this point in the history
* fix(Dropdown): rely on list-box height closes #4916

* fix(structuredlist): remove role=presentation, remove htmlFor attribute

Co-authored-by: TJ Egan <tw15egan@gmail.com>
  • Loading branch information
2 people authored and joshblack committed Jan 23, 2020
1 parent b20b689 commit 0f1f287
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ storiesOf('StructuredList', module)
() => {
const structuredListBodyRowGenerator = numRows => {
return Array.apply(null, Array(numRows)).map((n, i) => (
<StructuredListRow label key={`row-${i}`} htmlFor={`row-${i}`}>
<StructuredListRow label key={`row-${i}`}>
<StructuredListCell>Row {i}</StructuredListCell>
<StructuredListCell>Row {i}</StructuredListCell>
<StructuredListCell>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,7 @@ export class StructuredListRow extends Component {
{...other}
tabIndex={tabIndex}
className={classes}
onKeyDown={onKeyDown}
role="presentation" // eslint-disable-line jsx-a11y/no-interactive-element-to-noninteractive-role
>
onKeyDown={onKeyDown}>
{children}
</label>
) : (
Expand Down

0 comments on commit 0f1f287

Please sign in to comment.