Skip to content

Commit

Permalink
fix(combobox/text-input): add svg top positioning for IE11 (#5362)
Browse files Browse the repository at this point in the history
* fix(text-input): add top attribute to invalid svg for ie11

* fix(combobox): add css reset

* fix(combobox): add top positioning for ie11 fix

* fix(listbox): add non-magic number positioning solution for ei11

* fix(listbox/text-input): add correct comment style

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: Akira Sudoh <asudoh@gmail.com>
  • Loading branch information
4 people authored Feb 18, 2020
1 parent 8987ee7 commit 347185b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import '../../globals/scss/vars';
@import '../../globals/scss/vendor/@carbon/elements/scss/import-once/import-once';
@import '../list-box/list-box';
@import '../../globals/scss/css--reset';

/// Combo box styles
/// @access private
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/components/list-box/_list-box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ $list-box-menu-width: rem(300px);
.#{$prefix}--list-box__selection {
position: absolute;
right: rem(33px); // to preserve .5rem space between icons according to spec
// top/transform used to center invalid icon in IE11
top: 50%;
transform: translateY(-50%);
display: flex;
justify-content: center;
align-items: center;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
.#{$prefix}--text-input__invalid-icon {
position: absolute;
right: $carbon--spacing-05;
// top/transform used to center invalid icon in IE11
top: 50%;
transform: translateY(-50%);
fill: $support-01;
}

Expand Down

0 comments on commit 347185b

Please sign in to comment.