Skip to content

Commit

Permalink
fix: allow aria-controls optional in TableExpand(Header|Row) types (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
dbrugger authored Jan 11, 2024
1 parent 9592179 commit 58eda4f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type TableExpandHeaderPropsBase = {
/**
* Space separated list of one or more ID values referencing the TableExpandedRow(s) being controlled by the TableExpandHeader
*/
['aria-controls']: string;
['aria-controls']?: string;

/**
* @deprecated This prop has been deprecated and will be
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/components/DataTable/TableExpandRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ interface TableExpandRowProps extends PropsWithChildren<TableRowProps> {
/**
* Space separated list of one or more ID values referencing the TableExpandedRow(s) being controlled by the TableExpandRow
*/
['aria-controls']: string;
['aria-controls']?: string;

/**
* @deprecated This prop has been deprecated and will be
Expand Down Expand Up @@ -136,7 +136,6 @@ TableExpandRow.propTypes = {
* Space separated list of one or more ID values referencing the TableExpandedRow(s) being controlled by the TableExpandRow
* TODO: make this required in v12
*/
/**@ts-ignore*/
['aria-controls']: PropTypes.string,

/**
Expand Down

0 comments on commit 58eda4f

Please sign in to comment.