Skip to content

Commit

Permalink
fix(ui-shell): remove role banner from header ui-shell (#5077)
Browse files Browse the repository at this point in the history
Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
  • Loading branch information
2 people authored and joshblack committed Jan 23, 2020
1 parent c0803fd commit 7669299
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion packages/react/src/components/UIShell/Header.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Header = ({ className: customClassName, children, ...rest }) => {
const className = cx(`${prefix}--header`, customClassName);

return (
<header {...rest} className={className} role="banner">
<header {...rest} className={className}>
{children}
</header>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`Header should render 1`] = `
<header
aria-label="label"
className="bx--header custom-class"
role="banner"
/>
</Header>
`;

0 comments on commit 7669299

Please sign in to comment.