Skip to content

Commit

Permalink
fix(web-components): data table header size (#17881)
Browse files Browse the repository at this point in the history
removed hard coded min block sizes to allow the
header row to adjust height automatically for
each table size

Contributes to: #17680

Signed-off-by: Zoe Gathercole <zrgatherco@aol.com>
Co-authored-by: Guilherme Datilio Ribeiro <guilhermedatilio@gmail.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
  • Loading branch information
3 people authored Oct 28, 2024
1 parent e4386e6 commit d07171f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1697,6 +1697,15 @@
"contributions": [
"code"
]
},
{
"login": "Zoe-Gathercole",
"name": "Zoë Gathercole",
"avatar_url": "https://avatars.githubusercontent.com/u/56911544?v=4",
"profile": "https://github.com/Zoe-Gathercole",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
<td align="center"><a href="https://github.com/Thamjith"><img src="https://avatars.githubusercontent.com/u/24909620?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Thamjith Thaha</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Thamjith" title="Code">💻</a></td>
</tr>
<tr>
<td align="center"><a href="https://irfadkp.github.io/"><img src="https://avatars.githubusercontent.com/u/54243898?v=4?s=100" width="100px;" alt=""/><br /><sub><b>IRFAD KP</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=irfadkp" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/mariat189"><img src="https://avatars.githubusercontent.com/u/74430463?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Mariat</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=mariat189" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/Zoe-Gathercole"><img src="https://avatars.githubusercontent.com/u/56911544?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Zoë Gathercole</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Zoe-Gathercole" title="Code">💻</a></td>
</tr>
</table>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
justify-content: space-between;
block-size: 100%;
inline-size: 100%;
min-block-size: $spacing-09;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

:host(#{$prefix}-table-header-row)
::slotted(#{$prefix}-table-header-cell[sort-direction]) {
block-size: $spacing-09;
padding-inline: 0;
}

Expand Down

0 comments on commit d07171f

Please sign in to comment.