From d07171f02bc4fa019203f375964482fbc7261ead Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zo=C3=AB=20Gathercole?= <56911544+Zoe-Gathercole@users.noreply.github.com> Date: Mon, 28 Oct 2024 17:56:53 +0000 Subject: [PATCH] fix(web-components): data table header size (#17881) removed hard coded min block sizes to allow the header row to adjust height automatically for each table size Contributes to: carbon-design-system/carbon#17680 Signed-off-by: Zoe Gathercole Co-authored-by: Guilherme Datilio Ribeiro Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com> --- .all-contributorsrc | 9 +++++++++ README.md | 2 +- .../src/components/data-table/_table-core.scss | 1 - .../src/components/data-table/_table-sort.scss | 1 - 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index d061049851c9..07c487189857 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1697,6 +1697,15 @@ "contributions": [ "code" ] + }, + { + "login": "Zoe-Gathercole", + "name": "Zoë Gathercole", + "avatar_url": "https://avatars.githubusercontent.com/u/56911544?v=4", + "profile": "https://github.com/Zoe-Gathercole", + "contributions": [ + "code" + ] } ], "commitConvention": "none" diff --git a/README.md b/README.md index fe3b9c2f2fb4..a7ba718d4bba 100644 --- a/README.md +++ b/README.md @@ -314,8 +314,8 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
Thamjith Thaha

💻 -
IRFAD KP

💻
Mariat

💻 +
Zoë Gathercole

💻 diff --git a/packages/web-components/src/components/data-table/_table-core.scss b/packages/web-components/src/components/data-table/_table-core.scss index 11ee21748526..0d63364f1a7b 100644 --- a/packages/web-components/src/components/data-table/_table-core.scss +++ b/packages/web-components/src/components/data-table/_table-core.scss @@ -80,7 +80,6 @@ justify-content: space-between; block-size: 100%; inline-size: 100%; - min-block-size: $spacing-09; } } diff --git a/packages/web-components/src/components/data-table/_table-sort.scss b/packages/web-components/src/components/data-table/_table-sort.scss index 44eebcaa8323..09a96b50de6e 100644 --- a/packages/web-components/src/components/data-table/_table-sort.scss +++ b/packages/web-components/src/components/data-table/_table-sort.scss @@ -16,7 +16,6 @@ :host(#{$prefix}-table-header-row) ::slotted(#{$prefix}-table-header-cell[sort-direction]) { - block-size: $spacing-09; padding-inline: 0; }