Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs]: Refactor to provide TabList, TabPanels, TabPanel #10086

Closed
Tracked by #8487
tay1orjones opened this issue Nov 10, 2021 · 1 comment · Fixed by #10225
Closed
Tracked by #8487

[Tabs]: Refactor to provide TabList, TabPanels, TabPanel #10086

tay1orjones opened this issue Nov 10, 2021 · 1 comment · Fixed by #10225
Assignees
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Nov 10, 2021

The current implementation for tabs provides Tabs that contains one or more Tab. This issue is for refactoring the implementation to include separate components for the entire structure of Tabs to provide more flexibility and control.

Effectively the structure would be:

Tabs
  TabList
    Tab
  TabPanels
    TabPanel

This aligns with many other design systems approach to this component:

This will additionally impact the ability to more easily contain variants (line, contained, icon-only, etc) from #8487 without having to make new components.

@alexandertrefz
Copy link

FYI: The new TabPanels, TabPanel, and TabList components are not exposed through @carbon/react, however the refactored Tab Component is, effectively breaking the TabComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants