-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y]: toggletip implementation bugs #12922
Comments
Thanks for opening this! I'll try to hit each piece individually here:
Yeah this is intentional - we set the
Yes, this needs to be addressed.
Yes, this needs to be addressed.
The style documentation/spec does show a label and specifies it's typography tokens. @carbon-design-system/design Just to confirm, the intention is that Toggletip can be used with ToggletipLabel, FormLabel, or no label (as shown in the usage/anatomy on the site) One thing we did find additionally is that we need to update ToggletipLabel to be using body01 |
thanks @tay1orjones
Maybe it's possible to have one that does this that is ID'ed as doing that for that reason, and the rest behave as expected (not pre-opened)?
That's interesting. I can certainly see a situation where the i icon ends up at the end of a form label (thought I think that would be a separate thing outside the label name, right, since it's in the tab order independently? There's not need to have it announced as part of the input?) Seems pretty redundant. Why not just make the button say "info"? Not recommending that, but you see where I'm going, right? A button has a built-in label. A button with a label external to the button is almost a new one. |
Package
@carbon/react
Browser
Chrome
Operating System
MacOS
Package version
https://react.carbondesignsystem.com/?path=/story/components-toggletip--default
React version
No response
Automated testing tool and ruleset
n/a
Assistive technology
No response
Description
There are four primary challenges:
WCAG 2.1 Violation
Focus Order
Reproduction/example
https://react.carbondesignsystem.com/iframe.html?args=defaultOpen:true&id=components-toggletip--playground&viewMode=story
Steps to reproduce
Code of Conduct
The text was updated successfully, but these errors were encountered: