Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placeholder text from Dropdown/Multiselect fields #14308

Open
1 task done
Tracked by #15803
laurenmrice opened this issue Jul 26, 2023 · 2 comments
Open
1 task done
Tracked by #15803

Remove placeholder text from Dropdown/Multiselect fields #14308

laurenmrice opened this issue Jul 26, 2023 · 2 comments

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jul 26, 2023

After discussions with Accessibility we have decided to remove current placeholder text from the fields of Dropdown and Multiselect. However, the Multiselect and Filterable Multiselect selected states can still provide text in the field along with the number tag to help inform the user that options(s) are selected.

When we discussed this in the CAG call, there was potential dev concern around if this would be a breaking change for the end user if they were currently placeholder text in product for these components. It was mentioned that we could think about having a deprecation warning for placeholder text in dropdown and multiselect for a few releases if it makese sense to. For reference, we previously did this same change to the Select component #13008 and I know in the past we did this with Combobox and Filterable Multiselect.

Ref a11y issue: #3363


Design Spec

  • Below are the enabled states of what the Dropdown and Multiselect should look like.
  • Below are selected states of what the Multiselect and Filterable Multiselect should look like.
Frame 2

Code of Conduct

@laurenmrice laurenmrice added this to the 2023 Q3 milestone Jul 26, 2023
@laurenmrice laurenmrice changed the title [Feature Request] remove placeholder text from dropdown/multiselect fields [Feature Request] remove placeholder text from dropdown fields Jul 26, 2023
@laurenmrice laurenmrice changed the title [Feature Request] remove placeholder text from dropdown fields [Feature Request] remove placeholder text from dropdown/multiselect fields Jul 26, 2023
@tay1orjones
Copy link
Member

So the previous scope of this for Select was to just remove the placeholder text from the storybook stories, which is what we could start with here. Removing the actual prop for placeholder text would be a breaking change that we can't do right now.

@sstrubberg sstrubberg removed this from the 2023 Q3 milestone Aug 1, 2023
@sstrubberg sstrubberg added the version: 12 Issues pertaining to a future major release of Carbon label Aug 9, 2023
@sstrubberg sstrubberg mentioned this issue Feb 20, 2024
@thyhmdo
Copy link
Member

thyhmdo commented May 3, 2024

Just to document a few comments from @aubrey-oneal and @lesnider


Aubrey: I like having the helper text say 'select a fruit' so that it's clear they haven't made a choice yet. To avoid redundancy it then makes sense for the title to say Fruit. I do prefer the grayed out helper text but I see that it is 'outdated'. Is this an accessibility concern?


Laura:

  • The field label should be a noun (Fruit) and the in-field text should be a mild command or direction (Select a fruit).
  • If you label each field "Select a..." and there are multiple fields, users will eventually ignore the "Select a" part.
  • We do need the direction (Select a fruit) in the field right where users make a selection from the drop-down options, though, because visually challenged users who use screen readers need to know what to do and exactly where to do it.

An image for reference
default

@sstrubberg sstrubberg changed the title [Feature Request] remove placeholder text from dropdown/multiselect fields Remove placeholder text from Dropdown/Multiselect fields Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

4 participants