Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outstanding quirks with RTL mode after converting to CSS Logical Proeprties #14627

Closed
5 tasks done
Tracked by #14477
tw15egan opened this issue Sep 11, 2023 · 0 comments · Fixed by #14635
Closed
5 tasks done
Tracked by #14477

Fix outstanding quirks with RTL mode after converting to CSS Logical Proeprties #14627

tw15egan opened this issue Sep 11, 2023 · 0 comments · Fixed by #14635
Assignees

Comments

@tw15egan
Copy link
Member

tw15egan commented Sep 11, 2023

Refs #14580

  • - Checkbox - Skeleton example
    When using the margin in this format: margin: 1px 1px 1px 1px the values don’t get translate to “RTL”. Maybe we won't be able to use this method to write margin, padding, etc...

Screenshot 2023-09-08 at 14 21 10
Screenshot 2023-09-08 at 14 21 42

  • - CodeSnippet - Multiline, Singleline
    Horizontal scrollbar getting a blur in the left and right side

  • - Pagination
    Those arrow should change directions? I search a little bit and found these examples: 

    https://github.com/mui/mui-x/issues/8665

    https://bootstrap.rtlcss.com/docs/4.0/components/pagination/#working-with-icons
    From my understanding it shouldn’t, or am I wrong? Take PaginationNav as an example maybe. There the arrows kept the directions

  • - ProgressBar
    The ProgressBar should switch the side where it starts or kept the same side (left)

  • - Slider
    Seems like the Slider is getting the wrong value, maybe a logic would have to be written to switch the max and min values when in RTL mode (idk if we can track that in JS).

Originally posted by @guidari in #14580 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant