Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Accessibility Status: Enforce playwright tag naming convention #15370

Closed
5 of 6 tasks
Tracked by #13745
tay1orjones opened this issue Dec 11, 2023 · 1 comment · Fixed by #15692
Closed
5 of 6 tasks
Tracked by #13745

Component Accessibility Status: Enforce playwright tag naming convention #15370

tay1orjones opened this issue Dec 11, 2023 · 1 comment · Fixed by #15692
Assignees
Labels
proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 11, 2023

We've established that all e2e tests ran with playwright should have one of four tags:

carbon/docs/testing.md

Lines 46 to 53 in 670dffc

For avt tests, the test title should always include one of the following:
| Tag | Description |
| ---------------------- | ------------------------------------------------------------------------------------------------------------------------------ |
| `@avt` | High level/root tag that should wrap all avt tests. This is usually placed in a `describe` block title. |
| `@avt-default-state` | Sub-tag of `@avt`, used to tag individual tests covering the default state of a component. |
| `@avt-advanced-states` | Sub-tag of `@avt`, used to tag individual tests covering advanced states of a component (open/close, invalid, expanded, etc.). |
| `@avt-keyboard-nav` | Sub-tag of `@avt`, used to tag individual tests covering keyboard navigation flows. |

I think we can use eslint-plugin-playwright to enforce this naming convention now that they've added a valid-title rule in playwright-community/eslint-plugin-playwright#167

Tasks

@tay1orjones tay1orjones changed the title Enforce playwright tag naming convention Component Accessibility Status: Enforce playwright tag naming convention Dec 11, 2023
Copy link
Contributor

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

@tay1orjones tay1orjones added type: a11y ♿ role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Dec 11, 2023
@sstrubberg sstrubberg added this to the 2024 Q1 milestone Jan 8, 2024
@guidari guidari self-assigned this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: a11y ♿ type: enhancement 💡 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants