-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Carbon X] DatePicker color tokens applied with g90 and g100 themes have inaccessible color contrast #1710
Comments
So this isn't a blocker for us right now, since I can override colors selectively in our addons library to make them accessible. However, I really want to make sure I have the right intended color for the bottom border on the input element -- just so my override is in the right ballpark, at least. 🤔 @IBM/carbon-designers could anyone let me know what color that bottom input border should be for a g100 theme? Thank you 🙏 (EDIT: I'm referring to the bottom border color as shown below, before the input is select/focused/active) |
|
I'm waiting for #1795 to be merged (as I need the new |
@jendowns just a heads up, will pull out the updates into a two parts, I think. Hoping to have it done this morning if folks have a chance to leave feedback 👍 |
Sounds good -- thank you! |
@aagonzales Quick question -- That "selected" color (the start/end selected date in a range) and the text + "dot" color for the current date look like blue60 in these dark themes. The token used throughout looks like Am I correct that the blue for select/today should be blue40 (or even blue50) instead? Do you think |
@jendowns we're one step a head of you this time. We just added in a new |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions. |
I think this has been resolved with the addition of the |
Detailed description
A number of colors/tokens being applied to the DatePicker are not accessible when the
g100
org90
themes from@carbon/themes
are used.Here are some example screenshots...
g100 theme
Simple date picker
Range with min and max
g90 theme
Range
The text was updated successfully, but these errors were encountered: