-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read only text input #3018
Comments
@shixiedesign @emyarod Another proposal to consider (I created this issue prior to seeing @shixiedesign 's, so just some food for thought). The design was created for a slightly use case as none of the fields would be editable. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
As there's been no activity since this issue was marked as stale, we are auto-closing it. |
Not stale @shixiedesign |
Reopening this to restart some discussion - @aagonzales You had a question why tooltip is needed for read-only text input. I think @shixiedesign put this for overflow text, presumably it's difficult (or impossible) for user to go to non-editable text (input) box and move the cursor to see the whole content. That said, if we have an alternate design to go without tooltip for read-only text input, I think it'll be a good idea. What do you think? |
@asudoh where's the other issue this was mentioned in? (I couldn't find it again) |
@aagonzales Sorry I may not have been clear enough - It's #4015. The latest spec for read-only text input requests for a tooltip (presumably for overflow text). Definition tooltip is the closest, but definition tooltip (technically) cannot be activated by focus on |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
As there's been no activity since this issue was marked as stale, we are auto-closing it. |
Hi! Just wanted to follow up and see if there are any updates or changes to the design spec for this, regarding the last few comments about the tooltip. I know a handful of teams on our end need this, so I want to make sure I'm pointing them to the right place for design guidance unless there have been any changes. Is there an update on the implementation of this as well, or should our own teams start building this out? |
the design should be set already, but currently the implementation has been put on hold until further notice. when this is reprioritized I can update my previous PRs like #3054 |
Is there a readonly option for textinput at this time ? I think It's quite important for such a library |
@emyarod @shixiedesign Does anybody have updates on the status of this effort? The DataStage team on Cloud Pak for Data has a requirement for showing read-only fields in our connector properties panel. We consume the Elyra common canvas, so this would ideally be something that other teams using the canvas can leverage as well. |
Included in #2177, closing in favor of the other issue. |
ref: #2177 by @shixiedesign
A read only variant of Text input is suggested here: carbon-design-system/carbon-contribution#13 (comment)
Overview of component (updated May 13)
not-editable
icon, icon in PR Addedit--off
icon svg & update metadata.yml #2710not-editable
icon, to provide reason for the field being read-onlyreadonly
attributeDesign spec (updated May 13)
In context explorations:
Finalized design spec. Ready for dev 🤖 updated May 23
Light variant spec
Only difference from default is changing field background to
$field-01
so it is the same as background color.The text was updated successfully, but these errors were encountered: