Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 & Edge - Any Modal gets cropped off when resizing #3480

Closed
2 tasks done
Mikadv opened this issue Jul 22, 2019 · 4 comments
Closed
2 tasks done

IE11 & Edge - Any Modal gets cropped off when resizing #3480

Mikadv opened this issue Jul 22, 2019 · 4 comments
Labels

Comments

@Mikadv
Copy link

Mikadv commented Jul 22, 2019

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

Once a user uses Edge or Internet Explorer resizes a window under the size the modal has and then expanding the area again results in the modal being cropped off at the minimum position, leaving a half modal back.

Is this issue related to a specific component?

Modal

What did you expect to happen? What happened instead? What would you like to
see changed?

The modal should be shrink- and expandable to the original size without any difference. Or in other words, resizing should not destroy the UI.

What browser are you working in?

Chrome, Firefox, Edge, IE11

Bug in: Edge and IE11
Not in: Firefox and Chrome

What version of the Carbon Design System are you using?

v9 but also occurs in V10

Steps to reproduce the issue

  1. Open Edge

  1. Visit: http://react.carbondesignsystem.com/?path=/story/modal--default
  2. Drag the story part over the modal, such that it cuts it off.
  3. Minimize the window.
  4. The modal is already cropped off
  5. Expand it to maximum again and drag the story area down. What remains is a dialog that is cut in half.

2.2 Visit: https://www.carbondesignsystem.com/components/modal/code
3.2 Click on Show modal
4.2 Minimize the screen vertically such that it crops of the modal
5.2 Maximize and Minimize and then expand the window a bit vertically
6.2 The dialog is cropped off

Screenshots

cropped-minimitzed

cropped

6.2)
modal-cropped

@aledavila
Copy link
Contributor

Hi there thanks for reporting this. Sorry we are just getting to this. Would you mind reproducing this in a code sandbox
https://codesandbox.io/s/github/carbon-design-system/carbon/tree/master/packages/react/examples/codesandbox

It makes it easier on our team to debug and work on things. Sometimes we can see weird bugs with storybook.

@aledavila
Copy link
Contributor

Edit for team:

No longer a bug on Edge latest. Only found in IE11

@aledavila aledavila added priority: low severity: 4 https://ibm.biz/carbon-severity severity: 3 https://ibm.biz/carbon-severity and removed priority: high severity: 1 https://ibm.biz/carbon-severity severity: 4 https://ibm.biz/carbon-severity labels Dec 9, 2019
@Mikadv
Copy link
Author

Mikadv commented Dec 10, 2019

Somehow it is behaving still buggy in Edge but not that hard any longer:

  1. Visit https://codesandbox.io/s/trusting-frog-jxb39
  2. Shrink the window horizontally and vertically such that it is small but the modal doesn't cover all remaining space.
  3. Now expand the window only vertically
  4. Result: The modal wont resize any longer, only when the window is expanded horizontally again.

@asudoh
Copy link
Contributor

asudoh commented Dec 10, 2019

Hi 👋 thank you for reporting @Mikadv and doing investigations @aledavila! I think #4657 alleviates the the problem described here. Stay tuned for the next release - If you are interested, you can clone this repo and run yarn install && yarn build && chdir packages/react && yarn storybook there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants