Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe lifecycle methods from our components #4902

Closed
3 of 5 tasks
joshblack opened this issue Dec 17, 2019 · 0 comments · Fixed by #6307
Closed
3 of 5 tasks

Remove unsafe lifecycle methods from our components #4902

joshblack opened this issue Dec 17, 2019 · 0 comments · Fixed by #6307
Assignees
@joshblack
Labels
package: react carbon-components-react role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@joshblack
Copy link
Contributor

joshblack commented Dec 17, 2019 •
edited by abbeyhrt
Loading

We use UNSAFE_ lifecycle methods in several components that cause errors to be displayed in our storybook and to end-users. We should remove our usage of these components in the following components:

  • DatePicker
src/components/DatePicker/DatePicker.js:309:  UNSAFE_componentWillUpdate(nextProps) {
  • StructuredList
src/components/StructuredList/StructuredList.js:142:  UNSAFE_componentWillMount() {
  • ComboBox
src/components/ComboBox/ComboBox.js:202:  UNSAFE_componentWillReceiveProps(nextProps) {
  • DataTable
src/components/DataTable/DataTable.js:143:  UNSAFE_componentWillReceiveProps(nextProps) {
  • withState
src/tools/withState.js:16:  UNSAFE_componentWillMount() {
@abbeyhrt abbeyhrt self-assigned this Feb 21, 2020
@abbeyhrt abbeyhrt mentioned this issue Feb 21, 2020
Merged
@abbeyhrt abbeyhrt removed their assignment Feb 28, 2020
@alisonjoseph alisonjoseph mentioned this issue Jun 4, 2020
Closed
41 tasks
@joshblack joshblack self-assigned this Jun 17, 2020
@joshblack joshblack mentioned this issue Jun 17, 2020
Merged
@joshblack joshblack mentioned this issue Jun 30, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshblack joshblack

Labels
package: react carbon-components-react role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react): remove unsafe lifecycle methods from DataTable and DatePicker joshblack/carbon
3 participants
@mattrosno @joshblack @abbeyhrt