Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data table] Column header padding wrong #5360

Closed
aagonzales opened this issue Feb 14, 2020 · 3 comments · Fixed by #5366
Closed

[Data table] Column header padding wrong #5360

aagonzales opened this issue Feb 14, 2020 · 3 comments · Fixed by #5366

Comments

@aagonzales
Copy link
Member

Padding on table headers is currently 8px left/right but it should be 16px left/right

As-is:
image

@xxxle0
Copy link
Contributor

xxxle0 commented Feb 15, 2020

how about the padding of the table body ? if you change table header padding 8 px -> 16 px. I think the structure of table seems not consistent.
Screen Shot 2020-02-15 at 3 00 42 PM

@tw15egan
Copy link
Member

@xxxle0 I'm assuming each td in tbody should also be updated to be 1rem instead of the current .75rem to match the correct table headers

.#{$prefix}--data-table th,
.#{$prefix}--data-table td {
padding-left: $spacing-04;
padding-right: $spacing-04;

.#{$prefix}--data-table td,
.#{$prefix}--data-table tbody th {
background: $ui-01;
color: $text-02;
border-top: 1px solid $ui-01;
border-bottom: 1px solid $ui-03;
padding: rem(14px) $spacing-04;

@aagonzales
Copy link
Member Author

Opps yeah both should be updated. Great point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants