Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown, Mulitselect]: inline variants truncate text too early #5389

Closed
abbeyhrt opened this issue Feb 18, 2020 · 2 comments · Fixed by #5400
Closed

[Dropdown, Mulitselect]: inline variants truncate text too early #5389

abbeyhrt opened this issue Feb 18, 2020 · 2 comments · Fixed by #5400

Comments

@abbeyhrt
Copy link
Contributor

If you look at https://carbon-components-react.netlify.com/, you'll see that the inline variants for MultiSelect and Combobox truncate the text aft "O..." and the border bottom doesn't extend through the whole width.
Screen Shot 2020-02-18 at 11 58 46 AM
Screen Shot 2020-02-18 at 11 59 02 AM

@tw15egan
Copy link
Member

Seems like this was introduced via #4753, which takes in to account the various os behaviors and possible scrollbars when the checkmark is present...

@asudoh
Copy link
Contributor

asudoh commented Feb 19, 2020

Right @tw15egan @abbeyhrt my apologies for that. I think #4753 made the (inline-mode-only) right padding of the <div class="bx--list-box__menu-item__option"> redundant (given #4753 added a margin to the same element).

Wrt scroll bar, I suggest us not to do scroll bar detection, because it requires layout calculation that makes things complex and has performance problems. Ref: #4753 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants