Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[structured list] add background option #5410

Closed
laurenmrice opened this issue Feb 20, 2020 · 3 comments · Fixed by #14726
Closed

[structured list] add background option #5410

laurenmrice opened this issue Feb 20, 2020 · 3 comments · Fixed by #14726
Assignees
@guidari
Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: structured-list package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone
2023 Q4

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Feb 20, 2020 •
edited
Loading

Have an option to add a background to structured list.

Artboard
@laurenmrice
Copy link
Member Author

Discussion in Slack:
Screen Shot 2020-02-20 at 1 56 32 PM

@aagonzales aagonzales mentioned this issue Feb 20, 2020
Closed
24 tasks
@joshblack joshblack added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Mar 13, 2020
@tw15egan tw15egan added type: bug 🐛 and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Mar 13, 2020
@tw15egan
Copy link
Member

Blocked by:

#1937
#2820
#5065

@sstrubberg sstrubberg added version: 11 Issues pertaining to Carbon v11 proposal: open This request has gone through triaging. We're determining whether we take this on or not. package: @carbon/react @carbon/react adopter: PAL Work-stream that directly helps a Pattern & Asset Library. adopter: DSAG labels Nov 30, 2022
@sstrubberg sstrubberg added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Aug 22, 2023
@sstrubberg sstrubberg added this to the 2023 Q3 milestone Aug 23, 2023
@tay1orjones
Copy link
Member

tay1orjones commented Sep 6, 2023 •
edited
Loading

Right now this has a background: transparent; on the parent/containing element. We just need to update it to use $layer.

We could also add a vrt test for this with layer enabled.

@guidari guidari self-assigned this Sep 21, 2023
@guidari guidari mentioned this issue Sep 27, 2023
Merged
@tay1orjones tay1orjones modified the milestones: 2023 Q3, 2023 Q4 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guidari guidari

Labels
adopter: PAL Work-stream that directly helps a Pattern & Asset Library. component: structured-list package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
2023 Q4
Development

Successfully merging a pull request may close this issue.

feat: added $layer token in the background-color guidari/carbon
6 participants
@tay1orjones @joshblack @tw15egan @sstrubberg @laurenmrice @guidari