Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[button] inset focus needs to be transparent #7025

Closed
laurenmrice opened this issue Oct 12, 2020 · 4 comments · Fixed by #7029
Closed

[button] inset focus needs to be transparent #7025

laurenmrice opened this issue Oct 12, 2020 · 4 comments · Fixed by #7029

Comments

@laurenmrice
Copy link
Member

For the primary, secondary, tertiary and danger buttons, the focus state should have a 1px inset transparent space from the 2px focus border.

Spec example:
primary

In the documentation on the style tab, I do see that inverse-01 seems to be applied instead of a transparent space. Having an inset transparent space is the design intent.

@laurenmrice laurenmrice changed the title [button] inset focus neds to be transparent [button] inset focus needs to be transparent Oct 12, 2020
@tw15egan tw15egan self-assigned this Oct 12, 2020
@tw15egan
Copy link
Member

@laurenmrice, since this effect is being created by a box-shadow, setting this to transparent would make the space created by the inverse-01 to match the background color.

Screen Shot 2020-10-12 at 1 04 48 PM

I believe background-color will always paint to the border, so I'm not sure of a workaround.

@laurenmrice
Copy link
Member Author

laurenmrice commented Oct 12, 2020

In the dark themes right now, that inset 1px border is showing up as a color other than the ui-background and also not inverse-01
Ex:
Artboard

@tw15egan
Copy link
Member

tw15egan commented Oct 12, 2020

Seems like its set to ui-02? Should we update it to ui-background?

@laurenmrice
Copy link
Member Author

Yep, lets go with ui-background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants