Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker Content is not within a landmark element #7246

Closed
alon24 opened this issue Nov 9, 2020 · 6 comments · Fixed by #7465
Closed

Datepicker Content is not within a landmark element #7246

alon24 opened this issue Nov 9, 2020 · 6 comments · Fixed by #7465

Comments

@alon24
Copy link

alon24 commented Nov 9, 2020

Content is not within a landmark element
Violation
All content must reside within an element with a landmark role

image
image

@dakahn
Copy link
Contributor

dakahn commented Nov 20, 2020

Good catch. This violation is due to the date picker dialog rendering outside of the landmark region on the page (React, amirite?). Adding role="region" to the dialog itself should fix this issue.

@alon24
Copy link
Author

alon24 commented Nov 29, 2020

@dakahn any ETA on this ?
Or are you saying I have to do something in my code (This is run in a regular page not a dialog, so to which dialog do you mean?)

@alon24
Copy link
Author

alon24 commented Dec 7, 2020

any updates on this issue?

@dhyliu
Copy link

dhyliu commented Dec 15, 2020

@dakahn Are you going to fix the issue or are you expecting @alon24 to do some thing in his code and how? I'm focal responsible for making sure the accessibility support of applications running on IBM Cloud. We have some applications that apply the datepicker in their UI. I supposed this is likely not a unique issue impacting to single application. I'm looking forward to you quick advise. Thanks in advance.

@dakahn
Copy link
Contributor

dakahn commented Dec 15, 2020

Circling back on this. Sorry for the lack of communication. The ticket is in our backlog and we do plan to get to it, but no one is assigned to it as of yet. Taking a quick look at this and determining if it's a fix with Datepicker or if it's a fix with the underlying library we use to render our dialog. I'll post back when I have more information.

@dakahn
Copy link
Contributor

dakahn commented Dec 16, 2020

After investigating the solution seemed simple enough. Pushing up a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants