Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidi support: Hijri calendar is not supported #7265

Open
adir01 opened this issue Nov 10, 2020 · 3 comments
Open

Bidi support: Hijri calendar is not supported #7265

adir01 opened this issue Nov 10, 2020 · 3 comments

Comments

@adir01
Copy link

adir01 commented Nov 10, 2020

In some Arabic countries, usage in Hijri calendar is common, and even required according to law.
Hijri and Hebrew calendars are Lunar calendars, and therefore dates in these calendars are different from Gregorian used in European countries.

Examples:

  1. Date Picker
    Steps:
    Apply RTL style on Carbon
    Set calendar = Hijri

Gregorian calendar is actually shown:

image

@mattrosno , @joshblack FYI

@tw15egan
Copy link
Member

tw15egan commented Nov 10, 2020

Seems like we are blocked on the flatpickr side of things, as they do not support this calendar:

flatpickr/flatpickr#1526

#2585

@adir01
Copy link
Author

adir01 commented Nov 11, 2020

@wajnberg : I understand that the code on flatpickr/flatpickr#1526 was developed by you and I also understand that this code was written for Hijri calendar support in Watson Assistant which was completed. Can you please clarify the status of this PR on flatpickr ?

@wajnberg
Copy link

Hello @adir01

As mentioned in flatpickr/flatpickr#1526 (comment) they want to refactor the Hijri code as a plugin but they suspect it would cause tremendous amount of work. I will try to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

5 participants