From c9cd7ead55476cf1fbd6bcd8bb3a85588aa146f7 Mon Sep 17 00:00:00 2001
From: Abbey Hart <abbeyhrt@gmail.com>
Date: Mon, 16 Dec 2019 13:27:42 -0600
Subject: [PATCH 1/5] fix(search): add styles to address chrome'snew  autofill
 color

---
 .../components/src/components/search/_search.scss   | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/packages/components/src/components/search/_search.scss b/packages/components/src/components/search/_search.scss
index 1fe5a6bdfc05..8ea080276f02 100644
--- a/packages/components/src/components/search/_search.scss
+++ b/packages/components/src/components/search/_search.scss
@@ -72,6 +72,18 @@
     }
   }
 
+  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-close {
+    fill: currentColor;
+  }
+
+  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-close:hover {
+    background-color: #e5e5e5;
+  }
+
+  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-magnifier {
+    fill: black;
+  }
+
   .#{$prefix}--search-input[disabled] ~ .#{$prefix}--search-magnifier {
     fill: $disabled;
   }
@@ -123,7 +135,6 @@
     right: 0;
 
     &::before {
-      content: '';
       display: block;
       position: absolute;
       left: 0;

From dfb10a09b78909a8dc2a15aa9126c26372c683fd Mon Sep 17 00:00:00 2001
From: Abbey Hart <abbeyhrt@gmail.com>
Date: Mon, 16 Dec 2019 13:55:02 -0600
Subject: [PATCH 2/5] chore(search): remove extraneous style

---
 packages/components/src/components/search/_search.scss | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/packages/components/src/components/search/_search.scss b/packages/components/src/components/search/_search.scss
index 8ea080276f02..ee4cdfdd367f 100644
--- a/packages/components/src/components/search/_search.scss
+++ b/packages/components/src/components/search/_search.scss
@@ -80,10 +80,6 @@
     background-color: #e5e5e5;
   }
 
-  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-magnifier {
-    fill: black;
-  }
-
   .#{$prefix}--search-input[disabled] ~ .#{$prefix}--search-magnifier {
     fill: $disabled;
   }

From 5b5dc8c1835cebab13381793c9f688a2e198da26 Mon Sep 17 00:00:00 2001
From: Abbey Hart <abbeyhrt@gmail.com>
Date: Mon, 16 Dec 2019 16:26:12 -0600
Subject: [PATCH 3/5] fix(search): remove styles for deprecated custom buttons

---
 .../components/src/components/search/_search.scss    | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/packages/components/src/components/search/_search.scss b/packages/components/src/components/search/_search.scss
index ee4cdfdd367f..f20ed50784fe 100644
--- a/packages/components/src/components/search/_search.scss
+++ b/packages/components/src/components/search/_search.scss
@@ -130,18 +130,6 @@
     position: absolute;
     right: 0;
 
-    &::before {
-      display: block;
-      position: absolute;
-      left: 0;
-      top: rem(1px);
-      height: calc(100% - 2px);
-      width: 2px;
-      background-color: $field-01;
-      transition: background-color $duration--fast-02
-        motion(standard, productive);
-    }
-
     &:hover {
       border-bottom: 1px solid $ui-04;
     }

From 5ad5e22d467e653b5d1e8c774d746c5f69897d4f Mon Sep 17 00:00:00 2001
From: Abbey Hart <abbeyhrt@gmail.com>
Date: Wed, 18 Dec 2019 10:32:24 -0600
Subject: [PATCH 4/5] fix(search): remove autocomplete ability from input

---
 .../src/components/search/_search.scss        | 21 ++++++++++++-------
 .../react/src/components/Search/Search.js     |  1 +
 2 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/packages/components/src/components/search/_search.scss b/packages/components/src/components/search/_search.scss
index f20ed50784fe..1fe5a6bdfc05 100644
--- a/packages/components/src/components/search/_search.scss
+++ b/packages/components/src/components/search/_search.scss
@@ -72,14 +72,6 @@
     }
   }
 
-  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-close {
-    fill: currentColor;
-  }
-
-  .#{$prefix}--search-input:-webkit-autofill ~ .#{$prefix}--search-close:hover {
-    background-color: #e5e5e5;
-  }
-
   .#{$prefix}--search-input[disabled] ~ .#{$prefix}--search-magnifier {
     fill: $disabled;
   }
@@ -130,6 +122,19 @@
     position: absolute;
     right: 0;
 
+    &::before {
+      content: '';
+      display: block;
+      position: absolute;
+      left: 0;
+      top: rem(1px);
+      height: calc(100% - 2px);
+      width: 2px;
+      background-color: $field-01;
+      transition: background-color $duration--fast-02
+        motion(standard, productive);
+    }
+
     &:hover {
       border-bottom: 1px solid $ui-04;
     }
diff --git a/packages/react/src/components/Search/Search.js b/packages/react/src/components/Search/Search.js
index 4e8c04d70db1..4f08defba927 100644
--- a/packages/react/src/components/Search/Search.js
+++ b/packages/react/src/components/Search/Search.js
@@ -169,6 +169,7 @@ export default class Search extends Component {
         </label>
         <input
           role="searchbox"
+          autoComplete="off"
           {...other}
           type={type}
           className={`${prefix}--search-input`}

From 56fc1124df74cfc5a03a8ba4230a17c29f8f0d08 Mon Sep 17 00:00:00 2001
From: Abbey Hart <abbeyhrt@gmail.com>
Date: Wed, 18 Dec 2019 11:44:07 -0600
Subject: [PATCH 5/5] test(search): update snapshots

---
 .../DataTable/__tests__/__snapshots__/DataTable-test.js.snap    | 2 ++
 .../__tests__/__snapshots__/TableToolbarSearch-test.js.snap     | 1 +
 2 files changed, 3 insertions(+)

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
index 7891869cc3d0..5655a80b2a38 100644
--- a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
+++ b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2285,6 +2285,7 @@ exports[`DataTable should render 1`] = `
                       </label>
                       <input
                         aria-hidden={true}
+                        autoComplete="off"
                         className="bx--search-input"
                         id="custom-id"
                         onChange={[Function]}
@@ -3262,6 +3263,7 @@ exports[`DataTable sticky header should render 1`] = `
                       </label>
                       <input
                         aria-hidden={true}
+                        autoComplete="off"
                         className="bx--search-input"
                         id="custom-id"
                         onChange={[Function]}
diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
index 0739ce47f207..55c1bf937735 100644
--- a/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
+++ b/packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
@@ -71,6 +71,7 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
         </label>
         <input
           aria-hidden={true}
+          autoComplete="off"
           className="bx--search-input"
           id="custom-id"
           onChange={[Function]}