-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: security updates #6490
chore: security updates #6490
Conversation
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6490 +/- ##
==========================================
- Coverage 79.64% 79.63% -0.01%
==========================================
Files 394 394
Lines 12886 12886
Branches 4268 4268
==========================================
- Hits 10263 10262 -1
- Misses 2623 2624 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
But was just curious , like where are we using semver
in our repo?
@amal-k-joy It’s in our config CLI, but actually curious if that’s still in use at all or leftover from our v1 package. Can open a ticket to investigate and remove when I get home. That said, I also had to add a resolution for |
@amal-k-joy went ahead and removed the old/unused |
* chore: update rollup resolutions * chore: update express and path-to-regexp * chore: upgrade semver * chore: update webpack * chore: remove config/cli
473af0f
Contributes to #6337
What did you change?
rollup
resolutionsexpress
resolutions to resolvepath-to-regexp
semver
to resolutionswebpack
to latestHow did you test and verify your work?