Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SummaryCardBatchActions - buttons in tab order even when they appear "hidden" #339

Closed
jendowns opened this issue Jan 31, 2020 · 6 comments · Fixed by #341 or #340
Closed

SummaryCardBatchActions - buttons in tab order even when they appear "hidden" #339

jendowns opened this issue Jan 31, 2020 · 6 comments · Fixed by #341 or #340
Assignees
@jendowns
Labels
released on @canary released on @next released severity: 3 Low severity type: bug Something isn't working

Comments

@jendowns
Copy link
Contributor

Bug - summary card batch action buttons are always in tab order, even when hidden

Expected behavior -

The batch actions toolbar for the SummaryCardContainer (called SummaryCardBatchActions) should not be interactive when it is "hidden" from view. You shouldn't be able to tab those hidden batch actions buttons.

Actual behavior -

The batch actions buttons in SummaryCardBatchActions are in the tab order even when they appear "hidden"

Steps for reproducing

Go the storybook and see that you can tab to "hidden" batch actions buttons: https://ibm-security.carbondesignsystem.com/?path=/story/patterns-summarycard--multiselect
@jendowns jendowns added type: bug Something isn't working severity: 3 Low severity labels Jan 31, 2020
@jendowns jendowns mentioned this issue Jan 31, 2020
Merged
@jendowns jendowns self-assigned this Jan 31, 2020
@jendowns
Copy link
Contributor Author

NOTE: This issue originates from TableBatchActions and was resolved in the following PR: carbon-design-system/carbon#5081

@jendowns jendowns mentioned this issue Jan 31, 2020
Merged
@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 1.16.1-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jendowns
Copy link
Contributor Author

jendowns commented Feb 4, 2020

Reopening because this issue wasn't 100% resolved by #341 -- there's still an issue with consumer-added batch action buttons remaining interactive, in some cases.

@jendowns jendowns reopened this Feb 4, 2020
@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 1.16.1-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimonFinney
Copy link
Contributor

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jendowns jendowns

Labels
released on @canary released on @next released severity: 3 Low severity type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@SimonFinney @jendowns