From ae59ef5982946349889e4ae0cca281fcdcf35f43 Mon Sep 17 00:00:00 2001 From: sidney13 Date: Fri, 16 Oct 2020 11:04:10 -0700 Subject: [PATCH 1/2] Decision for proposal #42 (Create code review guidelines) This is a recreation of PR #137 that got stuck in git merge hell. --- proposals/p0042_decision.md | 47 +++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 proposals/p0042_decision.md diff --git a/proposals/p0042_decision.md b/proposals/p0042_decision.md new file mode 100644 index 0000000000000..8e490fe9a9ca7 --- /dev/null +++ b/proposals/p0042_decision.md @@ -0,0 +1,47 @@ +# Decision for: Create code review guidelines + + + +Proposal accepted on 2020-08-03 + +Affirming: + +- [austern](https://github.com/austern) +- [chandlerc](https://github.com/chandlerc) +- [geoffromer](https://github.com/geoffromer) +- [gribozavr](https://github.com/gribozavr) +- [zygoloid](https://github.com/zygoloid) + +Abstaining: + +- [josh11b](https://github.com/josh11b) +- [noncombatant](https://github.com/noncombatant) +- [tituswinters](https://github.com/tituswinters) + +## Open questions + +There were no open questions. + +## Rationale + +This proposal contains the right goals for the code review process in light of +our project goals, and the proposal is well-tailored to achieve them. +Specifically: + +- Ensure high quality of code, documentation, and other artifacts. We consider + these all "code reviews" regardless of whether the final artifact is "code" + in a technical sense. +- Encourage broad participation and contribution to the community through code + reviews. +- Ensure code reviews are inclusive, respectful, and welcoming. +- Have clear, discoverable, and mechanically enforced (where possible) rules + for who can, who should, and who must review any particular change. + +We want pre-commit rather than post-commit review, and we want all changes to go +through review. These guidelines are consistent with standard code review best +practice, including what’s described in the cited sources. + From ecdf9706b4a6aa31c3291ed305b1c0e8fe7ccab4 Mon Sep 17 00:00:00 2001 From: sidney13 Date: Fri, 16 Oct 2020 11:06:30 -0700 Subject: [PATCH 2/2] Results of running pre-commit --- proposals/README.md | 2 ++ proposals/p0042_decision.md | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/proposals/README.md b/proposals/README.md index c424dc1880fbf..2bdf116092cee 100644 --- a/proposals/README.md +++ b/proposals/README.md @@ -26,6 +26,7 @@ request: - [0029 - Linear, rebase, and pull-request GitHub workflow](p0029.md) - [Decision](p0029_decision.md) - [0042 - Create code review guidelines](p0042.md) + - [Decision](p0042_decision.md) - [0044 - Proposal tracking](p0044.md) - [Decision](p0044_decision.md) - [0051 - Goals](p0051.md) @@ -33,6 +34,7 @@ request: - [0074 - Change comment/decision timelines in proposal process](p0074.md) - [Decision](p0074_decision.md) - [0083 - In-progress design overview](p0083.md) + - [Decision](p0083_decision.md) - [0107 - Code and name organization](p0107.md) - [0120 - Add idiomatic code performance and developer-facing docs to goals](p0120.md) - [Decision](p0120_decision.md) diff --git a/proposals/p0042_decision.md b/proposals/p0042_decision.md index 8e490fe9a9ca7..e430613033427 100644 --- a/proposals/p0042_decision.md +++ b/proposals/p0042_decision.md @@ -44,4 +44,3 @@ Specifically: We want pre-commit rather than post-commit review, and we want all changes to go through review. These guidelines are consistent with standard code review best practice, including what’s described in the cited sources. -