-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0030: API to enumerate avilable wallets #253
Comments
I do something similar but then ccvault/eternl is twice as it's exposed as |
I do something similar - but much less accurate - https://github.com/GGAlanSmithee/use-cardano/blob/main/src/hooks/use-wallet-providers.tsx#L17. I think this issue is valid, what would the path be to move this to an actual CIP or ammendment? Just make a CPS? |
@GGAlanSmithee the last resolution of the CIP editors (it was back when minutes were still being transcribed into the repo, so you can probably find it) was for additional features for CIP-0030 to be submitted as CIPs with new numbers, because (as I remember; @KtorZ may remember in more detail or correct me if I'm wrong):
I don't work in this area so I can't advise about the right way of enumerating the available wallets. If there is a straightforward implementation that everyone can agree on quickly to do that, it should definitely be a CIP (with a (edit, p.s.: some of this may also apply to your last posting in #151 (comment)) |
@rphair many thanks for your quick reply. I will try to move this to a CIP then, since I think it could easily be done in the bridge API itself with introspection, much like @Mercurial does it. Regarding #151 I'm a bit more hesitant because I am not a wallet provider, but rather a consumer and idk the implications for the different implementations. As a consumer, i like how nami does it though. |
Please provide API to enumerate wallets available for dApp. Right now the only way is to iterate over properties in
window.cardano
but this lead to duplicated entries if you haveEternl
installed as due to avoid breaking changes to existing apps it's exposed twice via:window.cardano.ccvault
andwindow.cardano.eternl
The text was updated successfully, but these errors were encountered: