Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup system-level tests #4852

Closed
1 of 6 tasks
abailly opened this issue Nov 21, 2024 · 1 comment
Closed
1 of 6 tasks

Cleanup system-level tests #4852

abailly opened this issue Nov 21, 2024 · 1 comment
Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG CI CI related IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG TESTS Adding additional tests

Comments

@abailly
Copy link
Collaborator

abailly commented Nov 21, 2024

The problem that you wish to solve

There are currently 2 set of system-level tests within the cardano-wallet: one in Ruby and one in Haskell.

  • Those tests are overlapping, testing the c-w through its API and requiring a somewhat involved setup to run
  • They are complex and take a while to run which means they don't provide feedback to new developments fast enough to avoid delay and rework
  • The Ruby test suite is unmaintained and no one in the current team of maintainers has the skill nor the will to take that over
  • While e2e tests are generally easier to write, they are a liability to maintain as they accumulate over time and do not provide good support for modular code (see Test pyramid metaphor)

Description

This is a significant effort that will take some time, so this should be tackled piecemeal, a few tests at a time:

  • List existing tests in both technologies
  • Identify redundant and/or obsolete tests in the Ruby e2e suite and remove them
  • Identify gaps, ie. tests in Ruby e2e suite that are not in some ways covered by the Haskell integration tests
  • Port missing tests to Haskell
  • Identify Haskell integration tests that could be unit/component level tests
  • Port those tests to a lower-level

Implementation suggestions

No response

@abailly abailly added IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG labels Nov 21, 2024
@abailly abailly added TESTS Adding additional tests CI CI related labels Nov 21, 2024
@abailly
Copy link
Collaborator Author

abailly commented Dec 9, 2024

This effort might not bring enough value to be worth it

@abailly abailly closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG CI CI related IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG TESTS Adding additional tests
Projects
None yet
Development

No branches or pull requests

1 participant