From 4f353a3102fd11b6c7c5ea92e3bfd299d569373e Mon Sep 17 00:00:00 2001 From: Raphael Toledo Date: Fri, 17 Jan 2025 11:14:59 +0000 Subject: [PATCH] CriterionHelpers: Adding const sample_size and measuremen_time --- benches/centralized_telescope/number_steps.rs | 3 ++- benches/centralized_telescope/proving_time.rs | 3 ++- benches/centralized_telescope/verifying_time.rs | 3 ++- benches/common/criterion_helpers.rs | 3 +++ 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/benches/centralized_telescope/number_steps.rs b/benches/centralized_telescope/number_steps.rs index 84785b12..8220d196 100644 --- a/benches/centralized_telescope/number_steps.rs +++ b/benches/centralized_telescope/number_steps.rs @@ -60,9 +60,10 @@ fn step_benches(c: &mut Criterion) { mod criterion_group { #![allow(missing_docs)] use super::{criterion_group, step_benches, Criterion, Duration, Steps}; + use crate::utils::common::criterion_helpers::{MEASUREMENT_TIME_SEC, SAMPLE_SIZE}; criterion_group!(name = centralized_step; - config = Criterion::default().with_measurement(Steps).measurement_time(Duration::from_secs(30)).sample_size(200); + config = Criterion::default().with_measurement(Steps).measurement_time(Duration::from_secs(MEASUREMENT_TIME_SEC)).sample_size(SAMPLE_SIZE); targets = step_benches ); } diff --git a/benches/centralized_telescope/proving_time.rs b/benches/centralized_telescope/proving_time.rs index 5f2e7490..c4098478 100644 --- a/benches/centralized_telescope/proving_time.rs +++ b/benches/centralized_telescope/proving_time.rs @@ -51,9 +51,10 @@ fn proving_benches(c: &mut Criterion) { mod criterion_group { #![allow(missing_docs)] use super::{criterion_group, proving_benches, Criterion, Duration}; + use crate::utils::common::criterion_helpers::{MEASUREMENT_TIME_SEC, SAMPLE_SIZE}; criterion_group!(name = centralized_proving_time; - config = Criterion::default().measurement_time(Duration::from_secs(30)).sample_size(200); + config = Criterion::default().measurement_time(Duration::from_secs(MEASUREMENT_TIME_SEC)).sample_size(SAMPLE_SIZE); targets = proving_benches ); } diff --git a/benches/centralized_telescope/verifying_time.rs b/benches/centralized_telescope/verifying_time.rs index 976073f6..d83b2a7c 100644 --- a/benches/centralized_telescope/verifying_time.rs +++ b/benches/centralized_telescope/verifying_time.rs @@ -56,9 +56,10 @@ fn verify_benches(c: &mut Criterion) { mod criterion_group { #![allow(missing_docs)] use super::{criterion_group, verify_benches, Criterion, Duration}; + use crate::utils::common::criterion_helpers::{MEASUREMENT_TIME_SEC, SAMPLE_SIZE}; criterion_group!(name = centralized_verifying_time; - config = Criterion::default().measurement_time(Duration::from_secs(30)).sample_size(200); + config = Criterion::default().measurement_time(Duration::from_secs(MEASUREMENT_TIME_SEC)).sample_size(SAMPLE_SIZE); targets = verify_benches ); } diff --git a/benches/common/criterion_helpers.rs b/benches/common/criterion_helpers.rs index ef4cf2ee..692a76fc 100644 --- a/benches/common/criterion_helpers.rs +++ b/benches/common/criterion_helpers.rs @@ -6,6 +6,9 @@ use criterion::{ BenchmarkId, Criterion, Throughput, }; +pub const SAMPLE_SIZE: usize = 200; + +pub const MEASUREMENT_TIME_SEC: u64 = 30; pub mod centralized { use super::{BenchmarkId, Criterion, Measurement}; /// Benchmark parameters