Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit from internal wallet #954

Closed
v0d1ch opened this issue Jun 28, 2023 · 2 comments · Fixed by #1018
Closed

Remove commit from internal wallet #954

v0d1ch opened this issue Jun 28, 2023 · 2 comments · Fixed by #1018
Labels
green 💚 Low complexity or well understood feature 💬 feature A feature on our roadmap
Milestone

Comments

@v0d1ch
Copy link
Contributor

v0d1ch commented Jun 28, 2023

Why

We would to remove the old way of committing funds to a Head.

What

We already deprecated the use of the commit from internal workflow via the Commit client input message (websocket). Now we want to remove that capability complete and also drop mentions of marking fuel as that is not needed anymore. Any commit to a hydra node should be done via the #215 workflow.

How

Make sure we are using only external commits everywhere:

  • Remove Commit client input and related code so that there is no option for the clients to commit using a websocket message.
  • Grep the code base for the word fuel and remove all occurrences in the documentation/code comments. make sure that it's clear that any funds held by the internal wallet are fuel. No mentions of "marking fuel" remain in the docs.
  • Propagate internal commit changes in the hydra-tui package
  • Inspect our shell scripts and make sure they are updated
  • Demo video is not related anymore, record a new one?
@v0d1ch v0d1ch added the 💭 idea An idea or feature request label Jun 28, 2023
@v0d1ch v0d1ch mentioned this issue Jun 28, 2023
11 tasks
@ch1bo ch1bo changed the title Commit using external keys accross the codebase Remove commit from internal wallet Jun 28, 2023
@ch1bo ch1bo added this to the 0.12.0 milestone Jun 30, 2023
@v0d1ch v0d1ch changed the title Remove commit from internal wallet Repurpose commit from internal wallet Jul 4, 2023
@v0d1ch v0d1ch changed the title Repurpose commit from internal wallet Remove commit from internal wallet Jul 4, 2023
@v0d1ch v0d1ch added 💬 feature A feature on our roadmap green 💚 Low complexity or well understood feature and removed 💭 idea An idea or feature request labels Jul 4, 2023
@ghost ghost moved this to Next in Hydra Head Roadmap Jul 4, 2023
@pgrange
Copy link
Contributor

pgrange commented Jul 4, 2023

We should first do #966 so that existing clients don't have to implement a direct cardano-node connection after this change.

@ch1bo
Copy link
Collaborator

ch1bo commented Aug 17, 2023

Not required for 0.12.0 if not done in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
green 💚 Low complexity or well understood feature 💬 feature A feature on our roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants