Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-binstall doesn't work behind corporate firewall #1529

Closed
scalpel4k opened this issue Dec 15, 2023 · 7 comments
Closed

cargo-binstall doesn't work behind corporate firewall #1529

scalpel4k opened this issue Dec 15, 2023 · 7 comments

Comments

@scalpel4k
Copy link

Hi,

our pipelines are running behind a corporate firewall with custom TLS certificates. These are part of the certificate store, and curl, cargo and all other programs are working properly.

While cargo install for instance works, cargo binstall doesn't, despite having set SSL_CERT_FILE which was introduced in #774.

And here's the error message that I get when I'm trying to install something with cargo binstall

image

@passcod
Copy link
Member

passcod commented Dec 15, 2023

Ah, we changed the env var due to some conflict, it's BINSTALL_HTTPS_ROOT_CERTS or using the --root-certificates option on the command line. I'm not sure why we don't read from the system cert store though.

@NobodyXu
Copy link
Member

I recalled reading from system env somehow breaks our CI?

@scalpel4k
Copy link
Author

oh thanks, this actually did the trick. Now that I know reading the command line help would have helped .....

@Boscop
Copy link

Boscop commented Oct 3, 2024

Btw, why does cargo-binstall trigger Windows 11 Firewall to ask me if I want to allow it on public & private networks?
I declined and it still seemed to work to install a binary, so why is it necessary to allow it through the firewall? 🙂

@passcod
Copy link
Member

passcod commented Oct 4, 2024

cargo-binstall isn't the one triggering the firewall; probably better to ask Windows 11 why it's uselessly overzealous

@Boscop
Copy link

Boscop commented Oct 5, 2024

Hm, weird. Usually that firewall dialog only appears whenever an app tries to listen on a port.

@NobodyXu
Copy link
Member

NobodyXu commented Oct 5, 2024

Hm, weird. Usually that firewall dialog only appears whenever an app tries to listen on a port.

Well we definitely don't listen on any port, only connect to port for network requests and DNS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants