Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear emoji input on focus #1190

Closed
3 tasks done
BrnMarq opened this issue Nov 12, 2022 · 2 comments · Fixed by #1337
Closed
3 tasks done

Clear emoji input on focus #1190

BrnMarq opened this issue Nov 12, 2022 · 2 comments · Fixed by #1337
Labels
improvement Website improvements

Comments

@BrnMarq
Copy link

BrnMarq commented Nov 12, 2022

Description of the problem

Normally when I program and have to make commits I often try to use it the fastest possible, obviously, using the shortcuts that the page provides, such as CTRL + K, but after focusing the emoji search bar it doesn't clear the input. Probably should be good having it at least as an option in the config section

Solution

In the Toolbar component, before focusing the search bar, we could set the input value to an empty string

Alternatives

I've been also considering adding a config section, just to switch beetwen different modes of search, one that search and remove all other emojis(The one that is online), and another one that search and look for the one that you search and place it first, and the other would be placed just after that one(Like a sort)

Additional context

No response

Validations

@vhoyer
Copy link
Collaborator

vhoyer commented Nov 14, 2022

I think that a better way (for UX) to handle this problem is to have a clear button, that once the user clicks it, the input is cleared and focused automatically, this have the nice side effect of "not having to design a settings page/section/model", also it matches the native behavior of most places iirc.

since we already occupy the section where one would put a "clear" button with the "ctrl K" hint, we could toggle between the two states based on whether or not there is text in the field:

if there is text, we display the clear button, if there is no text, we display the "ctrl K" hint.

I think that this solution should serve your needs fairly well, am I correct? what does OP think of this suggestion?

@carloscuesta
Copy link
Owner

Hey!

I agree with @vhoyer, cleaning the input when doing the shortcut feels a bit weird to me in terms of user experience.

Adding a clear button when there's text sounds like a better solution to me!

@carloscuesta carloscuesta added the improvement Website improvements label Nov 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Website improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants