forked from WebPlatformForEmbedded/WPEWebKit
-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
21590 lines (13327 loc) · 734 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2017-10-04 Miguel Gomez <magomez@igalia.com>
Add animation support for WebP images
https://bugs.webkit.org/show_bug.cgi?id=113124
Reviewed by Žan Doberšek.
* Source/cmake/FindWebP.cmake:
2017-09-26 Zan Dobersek <zdobersek@igalia.com>
[CMake] Use implicit include directories for Clang as well
https://bugs.webkit.org/show_bug.cgi?id=177426
Reviewed by Michael Catanzaro.
In WebKitCompilerFlags.cmake, also gather and use the system
include directories for C and C++ build targets when compiling
with Clang. This fixes compilation errors when cross-building
WebKit with a Clang-based toolchain.
COMPILER_IS_GCC_OR_CLANG is used to check for GCC or Clang
compilers. That only checks for the C++ compiler, but it's not
reasonable to expect two widely different compilers being used
for C and C++ compilation.
* Source/cmake/WebKitCompilerFlags.cmake:
2017-09-25 Timothy Horton <timothy_horton@apple.com>
Make progress on getting Mac CMake building again
https://bugs.webkit.org/show_bug.cgi?id=177443
Unreviewed, just "fixing" the build.
* Source/cmake/OptionsMac.cmake:
Turn on WEB_CRYPTO on Mac. We need to do a bigger cleanup of feature
defines, but this one is important because we have SUBTLE_CRYPTO on
and there is some amount of interdependency.
2017-09-22 Per Arne Vollan <pvollan@apple.com>
[Win] WebKit is built as a static library, and not as a dll.
https://bugs.webkit.org/show_bug.cgi?id=177365
Reviewed by Brent Fulgham.
Set target type for WebKitLegacy target.
* Source/cmake/OptionsWin.cmake:
2017-09-22 Matt Lewis <jlewis3@apple.com>
Unreviewed, rolling out r222394.
This broke the Windows Debug Build.
Reverted changeset:
"Remove build-webkit's notion of feature flags having a
default value"
https://bugs.webkit.org/show_bug.cgi?id=177338
http://trac.webkit.org/changeset/222394
2017-09-22 Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338
Reviewed by Alex Christensen.
Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-09-20 Keith Miller <keith_miller@apple.com>
JSC should use unified sources for platform specific files.
https://bugs.webkit.org/show_bug.cgi?id=177290
Reviewed by Michael Saboff.
Change WEBKIT_COMPUTE_SOURCES CMake macro to look for platform
specific unified source lists. This is done in the same way that
we look for port specific configuration files. For example, if I
were building for the Mac port WEBKIT_COMPUTE_SOURCES would add
the Sources.txt and SourcesMac.txt source lists to the list of
unified sources.
* Source/cmake/WebKitMacros.cmake:
2017-09-20 Keith Miller <keith_miller@apple.com>
JSC Xcode build should use unified sources for platform independent files
https://bugs.webkit.org/show_bug.cgi?id=177190
Reviewed by Saam Barati.
Add a macro for collecting the set of "header" source files and adding the bundle
files to the "sources" list.
* Source/cmake/WebKitMacros.cmake:
2017-09-20 Michael Catanzaro <mcatanzaro@igalia.com>
REGRESSION(r222194) [WPE] Library and executable output names broken
https://bugs.webkit.org/show_bug.cgi?id=177273
Reviewed by Carlos Alberto Lopez Perez.
Move the WebKit2 output name variables from here to Source/WebKit.
* Source/cmake/OptionsWPE.cmake:
2017-09-20 Alberto Garcia <berto@igalia.com>
Fix HPPA and Alpha builds
https://bugs.webkit.org/show_bug.cgi?id=177224
Reviewed by Alex Christensen.
* CMakeLists.txt:
2017-09-19 Carlos Alberto Lopez Perez <clopez@igalia.com>
[CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
https://bugs.webkit.org/show_bug.cgi?id=177180
Reviewed by Michael Catanzaro.
This adds a ENABLE_WEB_CRYPTO flag and makes ENABLE_SUBTLE_CRYPTO depend on it.
The GTK and WPE ports enable them and set ENABLE_WEB_CRYPTO to public.
* Source/cmake/OptionsGTK.cmake: Set both features to ON and ENABLE_WEB_CRYPTO to public. No change in behaviour for GTK.
* Source/cmake/OptionsWPE.cmake: Do like on the GTK port. The public flag is now ENABLE_WEB_CRYPTO.
* Source/cmake/WebKitFeatures.cmake: Add the definition of ENABLE_WEB_CRYPTO and make ENABLE_SUBTLE_CRYPTO depend on it.
2017-09-18 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Rename WebKit target to WebKitLegacy and rename WebKit2 target to WebKit
https://bugs.webkit.org/show_bug.cgi?id=174558
Reviewed by Alex Christensen.
* CMakeLists.txt:
* Source/PlatformGTK.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitFS.cmake:
2017-09-18 Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com>
[Win][PAL] Move WebCoreHeaderDetection.h to PAL
https://bugs.webkit.org/show_bug.cgi?id=176990
Reviewed by Alex Christensen.
Create DerivedSources directory for PAL if WebCore build is enabled.
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitFS.cmake:
2017-09-15 Konstantin Tokarev <annulen@yandex.ru>
Consider enabling -Wno-expansion-to-defined for gcc 7
https://bugs.webkit.org/show_bug.cgi?id=167643
Reviewed by Michael Catanzaro.
Don't disable -Wexpansion-to-defined for Clang.
As suggested by Nico Weber, this warning produces false positives with
GCC only.
* Source/cmake/WebKitCompilerFlags.cmake:
2017-09-14 Yousuke Kimoto <yousuke.kimoto@sony.com>
[WinCairo] Add an option to build WebKitLegacy or WebKit
https://bugs.webkit.org/show_bug.cgi?id=176891
Added an option to build WebKitLegacy or WebKit.
Reviewed by Alex Christensen.
* Source/cmake/OptionsWin.cmake:
2017-09-13 Don Olmstead <don.olmstead@sony.com>
[CMake] Detect harfbuzz without pkgconfig
https://bugs.webkit.org/show_bug.cgi?id=176886
Reviewed by Michael Catanzaro.
* Source/cmake/FindHarfBuzz.cmake:
2017-09-07 Adrian Perez de Castro <aperez@igalia.com>
[WPE][CMake] Add "dist" and "distcheck" targets
https://bugs.webkit.org/show_bug.cgi?id=176448
Reviewed by Carlos Garcia Campos.
Add "dist" and "distcheck" CMake targets, which create release tarballs.
These are available only when configuring with -DDEVELOPER_MODE=TRUE.
* Source/PlatformWPE.cmake: Added.
* Source/cmake/FindXz.cmake: Added.
2017-09-05 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Wrong use of PLUGIN_ARCHITECTURE(X11) in several places
https://bugs.webkit.org/show_bug.cgi?id=176329
Reviewed by Michael Catanzaro.
Only define MOZ_X11 if X11 target is enabled and always define XP_UNIX if NETSCAPE_PLUGIN_API is enabled.
* Source/cmake/OptionsGTK.cmake:
2017-09-03 Sam Weinig <sam@webkit.org>
Remove CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=176288
Reviewed by Yusuke Suzuki.
CanvasProxy does not appear to be in any current HTML spec
and was disabled and unimplemented in our tree. Time to
get rid of it.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-31 Don Olmstead <don.olmstead@sony.com>
[CMake] Make USE_CF conditional within Windows
https://bugs.webkit.org/show_bug.cgi?id=176173
Reviewed by Alex Christensen.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:
2017-08-30 Don Olmstead <don.olmstead@sony.com>
[CMake][WinCairo] Use find_package for libpng and libjpeg
https://bugs.webkit.org/show_bug.cgi?id=176113
Reviewed by Alex Christensen.
* Source/cmake/OptionsWinCairo.cmake:
2017-08-30 Carlos Alberto Lopez Perez <clopez@igalia.com>
[WPE] Enable MEMORY_SAMPLER
https://bugs.webkit.org/show_bug.cgi?id=176099
Reviewed by Michael Catanzaro.
Enable the otion at build time by default on Linux (currently
there are only Linux and Mac implementations of this feature).
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsGTK.cmake:
2017-08-30 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix versions numbers after r221136.
We normally use .0 in trunk after branching, and bump to .1 when making the first unstable release. We also need
to bump the library version.
* Source/cmake/OptionsGTK.cmake:
2017-08-29 Don Olmstead <don.olmstead@sony.com>
[CMake] Use find_package for zlib
https://bugs.webkit.org/show_bug.cgi?id=176075
Reviewed by Alex Christensen.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:
2017-08-29 Don Olmstead <don.olmstead@sony.com>
[CMake] Use find_package for libxml2 and libxstl
https://bugs.webkit.org/show_bug.cgi?id=176042
Reviewed by Konstantin Tokarev.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:
2017-08-24 Tomas Popela <tpopela@redhat.com>
Bump trunk version to be 2.19.1
Rubber-stamped by Michael Catanzaro.
* Source/cmake/OptionsGTK.cmake:
2017-08-24 Don Olmstead <don.olmstead@sony.com>
[CMake] Use find_package for SQLite
https://bugs.webkit.org/show_bug.cgi?id=175803
Reviewed by Konstantin Tokarev.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:
2017-08-23 Xabier Rodriguez Calvar <calvaris@igalia.com>
[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625
Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/GStreamerChecks.cmake: Added.
* Source/cmake/GStreamerDefinitions.cmake: Added.
* Source/cmake/GStreamerDependencies.cmake: Added.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-08-22 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r221006.
https://bugs.webkit.org/show_bug.cgi?id=175821
generates build failures in the bots (Requested by calvaris[m]
on #webkit).
Reverted changeset:
"[GStreamer][GTK][WPE] Move common things to GStreamer cmake
files"
https://bugs.webkit.org/show_bug.cgi?id=175625
http://trac.webkit.org/changeset/221006
2017-08-22 Xabier Rodriguez Calvar <calvaris@igalia.com>
[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625
Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.
Reviewed by Žan Doberšek.
* Source/cmake/GStreamerChecks.cmake: Added.
* Source/cmake/GStreamerDefinitions.cmake: Added.
* Source/cmake/GStreamerDependencies.cmake: Added.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-08-17 Andreas Kling <akling@apple.com>
Disable CSS regions at compile time
https://bugs.webkit.org/show_bug.cgi?id=175630
Reviewed by Antti Koivisto.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-14 Simon Fraser <simon.fraser@apple.com>
Remove Proximity Events and related code
https://bugs.webkit.org/show_bug.cgi?id=175545
Reviewed by Daniel Bates.
No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-14 Simon Fraser <simon.fraser@apple.com>
Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
https://bugs.webkit.org/show_bug.cgi?id=175557
Reviewed by Jon Lee.
No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-14 Adrian Perez de Castro <aperez@igalia.com>
[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507
Reviewed by Michael Catanzaro.
Remove "_GLIB" from user-agent version macros.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-08-13 Adrian Perez de Castro <aperez@igalia.com>
[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507
Reviewed by Carlos Alberto Lopez Perez.
Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.
* Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
* Source/cmake/OptionsWPE.cmake: Add UA version macros.
2017-08-11 Ryosuke Niwa <rniwa@webkit.org>
Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
https://bugs.webkit.org/show_bug.cgi?id=175474
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-11 Konstantin Tokarev <annulen@yandex.ru>
[CMake] Fix broken use of REQUIRED with find modules
https://bugs.webkit.org/show_bug.cgi?id=175427
Reviewed by Michael Catanzaro.
Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.
To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).
* Source/cmake/FindGTKUnixPrint.cmake:
* Source/cmake/FindGeoClue2.cmake:
* Source/cmake/FindHyphen.cmake:
* Source/cmake/FindLibEpoxy.cmake:
* Source/cmake/FindLibGBM.cmake:
* Source/cmake/FindLibsecret.cmake:
* Source/cmake/FindLibtasn1.cmake:
* Source/cmake/FindLibxkbcommon.cmake:
* Source/cmake/FindOpenGL.cmake:
* Source/cmake/FindOpenGLES2.cmake:
* Source/cmake/FindOpenWebRTC.cmake:
* Source/cmake/FindWPEBackend-mesa.cmake:
* Source/cmake/FindWPEBackend.cmake:
* Source/cmake/FindWayland.cmake:
* Source/cmake/FindWebP.cmake:
* Source/cmake/OptionsGTK.cmake:
2017-08-10 Michael Catanzaro <mcatanzaro@igalia.com>
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/FindGeoClue2.cmake:
2017-08-10 Michael Catanzaro <mcatanzaro@igalia.com>
Remove ENABLE_GAMEPAD_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=175361
Reviewed by Carlos Garcia Campos.
* Source/cmake/FindGUdev.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-08-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426
Reviewed by Carlos Garcia Campos.
Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.
* Source/cmake/FindGeoClue2.cmake:
2017-08-09 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK] Remove support for geoclue1
https://bugs.webkit.org/show_bug.cgi?id=164205
Reviewed by Carlos Garcia Campos.
* Source/cmake/FindGeoClue.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
2017-08-09 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Remove unused find modules
https://bugs.webkit.org/show_bug.cgi?id=175363
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/FindCFLite.cmake: Removed.
* Source/cmake/FindClang.cmake: Removed.
* Source/cmake/FindDBus.cmake: Removed.
* Source/cmake/FindDirectX.cmake: Removed.
* Source/cmake/FindEspeak.cmake: Removed.
* Source/cmake/FindQuickTimeSDK.cmake: Removed.
2017-08-09 Zan Dobersek <zdobersek@igalia.com>
[WPE] Enable SUBTLE_CRYPTO in release builds
https://bugs.webkit.org/show_bug.cgi?id=175371
Reviewed by Carlos Garcia Campos.
* Source/cmake/OptionsWPE.cmake:
Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.
2017-08-09 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
https://bugs.webkit.org/show_bug.cgi?id=172758
Reviewed by Žan Doberšek.
Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.
* Source/cmake/OptionsGTK.cmake:
2017-08-08 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Properly test if compiler supports compiler flags
https://bugs.webkit.org/show_bug.cgi?id=174490
Reviewed by Konstantin Tokarev.
This turned out to be a massive pain. I didn't want to merely check options before using
them: I also wanted to organize the code to avoid setting similar flags in different places.
Right now we set a bunch of global flags in OptionsCommon.cmake, and a bunch more flags in
WEBKIT_SET_EXTRA_COMPILER_FLAGS on a per-target basis.
Setting flags per-target seems better in general, e.g. because it makes it very easy to
disable warnings for particular ThirdParty targets. But it turns out that all the flags set
on a per-target basis get passed to both the C compiler and the C++ compiler, so it's
impossible to pass C++-only flags there. That's terrible. It's possible to make the flags
language-conditional using generator expressions, but that doesn't work for the Visual
Studio backend, so we would have to drop support for that (not going to happen). The CMake
documentation suggests that C and C++ files ought to be built in separate targets to avoid
this. It's a mess, basically.
So I've wound up removing WEBKIT_SET_EXTRA_COMPILER_FLAGS and adding most of those flags to
CMAKE_C_FLAGS and CMAKE_CXX_FLAGS instead. Really the only disadvantage of this is we now
have to suppress individual warnings when building ANGLESupport in WebCore. That's not the
end of the world. The only remaining useful feature of WEBKIT_SET_EXTRA_COMPILER_FLAGS was
to add -fPIC to static library targets, but turns out CMake does that for us if we just set
the variable CMAKE_POSITION_INDEPENDENT_CODE, so we can get rid of it completely.
Of course there are also macros for setting target-specific compiler flags, which we
frequently need in order to suppress specific warnings, particularly warnings coming from
third-party libraries like ANGLE and gtest. But remember the footgun: these macros will test
the flag against only one compiler, but must work with both C and C++ compilers unless the
build target exclusively contains targets built with just one of those compilers. Yuck.
* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/PlatformGTK.cmake:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitCompilerFlags.cmake: Added.
* Source/cmake/WebKitMacros.cmake:
2017-08-07 Brian Burg <bburg@apple.com>
Remove CANVAS_PATH compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175207
Reviewed by Sam Weinig.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-03 Brian Burg <bburg@apple.com>
Remove ENABLE(WEB_SOCKET) guards
https://bugs.webkit.org/show_bug.cgi?id=167044
Reviewed by Joseph Pecoraro.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-03 Brady Eidson <beidson@apple.com>
Add SW IDLs and stub out basic functionality.
https://bugs.webkit.org/show_bug.cgi?id=175115
Reviewed by Chris Dumez.
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-08-01 Brady Eidson <beidson@apple.com>
Part 1 of: Rename DatabaseProcess to StorageProcess.
https://bugs.webkit.org/show_bug.cgi?id=174879
Reviewed by Andy Estes.
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/gtksymbols.filter:
2017-08-01 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later
https://bugs.webkit.org/show_bug.cgi?id=174855
Reviewed by Carlos Garcia Campos.
Create derived sources directories in WebKitCommon.cmake instead of WebKitFS.cmake, which is
too soon. I tried changing the include order, but other stuff in WebKitFS.cmake really is
needed before including the port options file.
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitFS.cmake:
2017-07-29 Yusuke Suzuki <utatane.tea@gmail.com>
Unreviewed, build fix for GTK and WPE about StorageProcess renaming
* Source/cmake/OptionsWPE.cmake:
2017-07-28 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r219986.
https://bugs.webkit.org/show_bug.cgi?id=174962
"broke PLT on iOS (rdar://problem/33602751)" (Requested by
estes on #webkit).
Reverted changeset:
"Part 1 of: Rename DatabaseProcess to StorageProcess."
https://bugs.webkit.org/show_bug.cgi?id=174879
http://trac.webkit.org/changeset/219986
2017-07-28 Adrian Perez de Castro <aperez@igalia.com>
[GTK] Building with ENABLE_VIDEO=OFF fails
https://bugs.webkit.org/show_bug.cgi?id=174940
Reviewed by Alex Christensen.
Code guarded by ENABLE(MEDIA_STREAM) requires the definition of HTMLVideoElement to
be available, which in turn is guarded by ENABLE(VIDEO).
* Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_STREAM depend on ENABLE_VIDEO.
2017-07-28 Claudio Saavedra <csaavedra@igalia.com>
[WPE] Implement EventSenderProxy in WTR
https://bugs.webkit.org/show_bug.cgi?id=173419
Reviewed by Žan Doberšek.
Add the implementation of EventSenderProxy to the WTR. This
allows us to extend the coverage of the test suite in WKWPE.
* Source/cmake/FindLibxkbcommon.cmake: Added.
2017-07-28 Zan Dobersek <zdobersek@igalia.com>
Unreviewed. Bumping the patch version for WPEWebKit library to 20170728.
* Source/cmake/OptionsWPE.cmake:
2017-07-27 Brady Eidson <beidson@apple.com>
Part 1 of: Rename DatabaseProcess to StorageProcess.
https://bugs.webkit.org/show_bug.cgi?id=174879
Reviewed by Andy Estes.
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/gtksymbols.filter:
2017-07-26 Brady Eidson <beidson@apple.com>
Remove DATABASE_PROCESS build flag.
https://bugs.webkit.org/show_bug.cgi?id=174868
Reviewed by Andy Estes.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-07-26 Brian Burg <bburg@apple.com>
Remove WEB_TIMING feature flag
https://bugs.webkit.org/show_bug.cgi?id=174795
Reviewed by Alex Christensen.
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2017-07-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix WebKit2 derived sources directory creation after r219488.
The variable is still DERIVED_SOURCES_WEBKIT2_DIR, not DERIVED_SOURCES_WEBKIT_DIR. Build was not really affected
because WebKit2 makefile creates the directory too.
* Source/cmake/WebKitFS.cmake:
2017-07-26 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.5 release.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2017-07-25 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Fix GTK+ WebKit2 library soname after r219488.
The WebKit2 -> WebKit rename shouldn't affect the GTK+ library that is still called libwebkit2gtk, so keep using
WEBKIT2 as the library name in CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE, since that's also what the WebKit
makefile passes to WEBKIT_POPULATE_LIBRARY_VERSION.
* Source/cmake/OptionsGTK.cmake:
2017-07-24 Zan Dobersek <zdobersek@igalia.com>
[WPE] Add libepoxy to the Jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=174711
Reviewed by Carlos Alberto Lopez Perez.
libepoxy 1.3.1 that's widely available in current stable distributions (Debian stable,
Ubuntu LTS) does suffice our needs, but also contains a bug that incorrectly determines
the current EGL context and the API version of OpenGL that's bound to that context.
Focusing on experiences on Debian systems, while the current stable Debian release has
this bug patched, the package for the testing distribution of Debian removed that same
patch for whatever reason, despite using the 1.3.1 version as the package basis.
To avoid this, libepoxy 1.4.3 is now added to WPE's Jhbuild moduleset. The WPE port
also now demands at least the 1.4.0 version to be available when configuring.
We should revisit the minimum version for libepoxy in the future if the 1.3 release
branch gets updated with the proper fix.
* Source/cmake/FindLibEpoxy.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-07-21 Konstantin Tokarev <annulen@yandex.ru>
[cmake] Unreviewed, add definitions necessary to use ICU shipped with macOS
macOS system ICU libraries are built with U_DISABLE_RENAMING=1 and
U_SHOW_CPLUSPLUS_API=0. After r219155 we have to pass this definitons
explicitly, because ICU headers in the tree are not modified anymore.
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
2017-07-17 Carlos Garcia Campos <cgarcia@igalia.com>
Add initial implementation of WebDriver process to run the HTTP server
https://bugs.webkit.org/show_bug.cgi?id=166682
Reviewed by Brian Burg.
Enable WebDriver in the GTK port by default.
* Source/CMakeLists.txt:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFS.cmake:
* Source/cmake/WebKitFeatures.cmake:
2017-07-17 Konstantin Tokarev <annulen@yandex.ru>
[cmake] Set library types before their targets are created
https://bugs.webkit.org/show_bug.cgi?id=174600
Reviewed by Michael Catanzaro.
Since r219560 library targets are created before PlatformXXX.cmake
files are processed, however library type must be passed in
add_library() call and cannot be changed afterwards. Set these
variables in OptionsXXX.cmake.
* CMakeLists.txt:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
2017-07-17 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Include most CMake modules from WebKitCommon.cmake
https://bugs.webkit.org/show_bug.cgi?id=174546
Reviewed by Konstantin Tokarev.
* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitMacros.cmake:
2017-07-17 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
https://bugs.webkit.org/show_bug.cgi?id=174547
Reviewed by Alex Christensen.
* Source/cmake/WebKitMacros.cmake:
2017-07-17 Konstantin Tokarev <annulen@yandex.ru>
[CMake] Create targets before WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS is called
https://bugs.webkit.org/show_bug.cgi?id=174557
Reviewed by Michael Catanzaro.
* Source/cmake/WebKitMacros.cmake:
2017-07-16 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Raise minimum CMake requirement
https://bugs.webkit.org/show_bug.cgi?id=174545
Reviewed by Konstantin Tokarev.
* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
2017-07-14 Michael Catanzaro <mcatanzaro@igalia.com>
[CMake] Unclear distinction between WebKitHelpers and WebKitMacros
https://bugs.webkit.org/show_bug.cgi?id=153189
Reviewed by Antonio Gomes.
Merge WebKitHelpers.cmake into WebKitMacros.cmake, since there is no meaningful distinction
between the macros that belong in each file. Then, move the macros that are only needed by
one project into project-specific CMake files. Retain here only the macros that are needed
in multiple places.
* Source/cmake/OptionsCommon.cmake: Update a comment.
* Source/cmake/OptionsGTK.cmake: New location for libtool macro, exclusively needed here.
* Source/cmake/WebKitCommon.cmake: Do not include WebKitHelpers.cmake.
* Source/cmake/WebKitHelpers.cmake: Removed.
* Source/cmake/WebKitMacros.cmake:
2017-07-13 Michael Catanzaro <mcatanzaro@igalia.com>
[GTK][WPE] Avoid setting settings that are set by default
Unreviewed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2017-07-13 Konstantin Tokarev <annulen@ynadex.ru>
Unreviewed, Windows ports should enable WebKitLegacy and disable
WebKit.
* Source/cmake/OptionsWin.cmake:
2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
Fix the Mac CMake build.
Unreviewed build fix.
Fix the Mac CMake build after r219488 broke it. r219488 erroneously updated
the variable name DERIVED_SOURCES_WEBKITLEGACY_DIR to DERIVED_SOURCES_WEBKIT_LEGACY_DIR
without updating subsequent users of that variable.
* Source/cmake/WebKitFS.cmake:
Rename DERIVED_SOURCES_WEBKIT_LEGACY_DIR back to DERIVED_SOURCES_WEBKITLEGACY_DIR.
2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
Fix the cMake builds (GTK and WPE.)
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
* Source/CMakeLists.txt:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFS.cmake:
* Source/cmake/WebKitPackaging.cmake:
2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
Rename WebKit2.xcodeproj to WebKit.xcodeproj.
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
* WebKit.xcworkspace/contents.xcworkspacedata:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-07-13 Matthew Hanson <matthew_hanson@apple.com>
Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=174164
rdar://problem/33137595
Reviewed by Dan Bernstein.
* Source/Makefile:
* Source/PlatformGTK.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFS.cmake:
* Source/cmake/WebKitPackaging.cmake:
* WebKit.xcworkspace/contents.xcworkspacedata:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-07-05 Matthew Hanson <matthew_hanson@apple.com>
Update the Xcode project name from WebKit to WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=174162
rdar://problem/33137594
Reviewed by Dan Bernstein.
Rename WebKit to WebKitLegacy.
* WebKit.xcworkspace/contents.xcworkspacedata:
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2017-07-05 Matthew Hanson <matthew_hanson@apple.com>
Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=174162
rdar://problem/33137594