get_filter_name is now a classmethod #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… each FilterClass, addressing issue carltongibson#774
Codecov Report
@@ Coverage Diff @@
## develop #775 +/- ##
========================================
Coverage 98.36% 98.36%
========================================
Files 15 15
Lines 1220 1220
========================================
Hits 1200 1200
Misses 20 20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
get_filter_namefrom a function to a static class method, which enables developers to override this method for each filter.This is addressing issue #774, and helps developers that want to define an alias for a field with many comperators, and still want to use the very convenient and intuitive API of the filtering with
field_name__gte,field_name__lte, ...