Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty value check for CSV range #854

Merged
merged 3 commits into from
Jul 13, 2018

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Jan 16, 2018

CSV ranges currently don't accept empty values. This is acceptable in API use, but not for forms.

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #854 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   98.07%   97.95%   -0.13%     
==========================================
  Files          15       15              
  Lines        1144     1123      -21     
==========================================
- Hits         1122     1100      -22     
- Misses         22       23       +1
Impacted Files Coverage Δ
django_filters/fields.py 100% <100%> (ø) ⬆️
django_filters/filters.py 98.42% <0%> (-0.37%) ⬇️
django_filters/rest_framework/filterset.py 100% <0%> (ø) ⬆️
django_filters/filterset.py 100% <0%> (ø) ⬆️
django_filters/rest_framework/filters.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a74da...e540f28. Read the comment docs.

@carltongibson carltongibson merged commit 72dd94d into carltongibson:master Jul 13, 2018
@rpkilby rpkilby deleted the fix-csv-range branch July 13, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants