Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dashes in Python module names #115

Closed
milanmlft opened this issue Jul 3, 2024 · 1 comment · Fixed by #133
Closed

Avoid dashes in Python module names #115

milanmlft opened this issue Jul 3, 2024 · 1 comment · Fixed by #133
Assignees
@SJaffa

Comments

@milanmlft
Copy link

Not sure if it appears anywhere in the course material, but during the workshop there was a point where a eva-data-analysis.py file was created and then imported as a module into another script.
However, using - in Python module names is not PEP8-compliant. Using _ is probably a better idea.
@anenadic
Copy link
Collaborator

anenadic commented Jul 3, 2024

We should make this a callout and also maybe use underscores for data file names to be consistent and avoid cognitive overload for learners.

@SJaffa SJaffa mentioned this issue Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SJaffa SJaffa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistently use underscores instead of hyphens in filenames SJaffa/fair-research-software
3 participants
@anenadic @SJaffa @milanmlft