-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve caching and file permissions in make docker-serve
#663
Comments
Ah, I noticed that there is already a It seems to run I've started working on a small improvement (gh-pages...rkm:gh-pages) which has the following advantages:
Would you like me to make a PR for this? |
Hi @rkm, Thank you for this! In my experience with the Jekyll Docker container, it can be a bit finnicky with the host permissions. I had previously set up a docker container for maintaining lessons at https://github.com/carpentries/lesson-docker/#docker-container-for-lesson-maintenance that will work for the workshop-template and has a couple of advantages:
Let me know what you think. |
Thanks! I'll take a look at that although the docker image seems a little heavy at ~1.4GB. I was only hoping to contribute a small usability fix to the current workflow in this repo, so apologies if this has raised more questions than it has answered! FWIW I believe I have fixed the permissions issues on my branch, so the only remaining issue I see is that of the jekyll/ruby version pinning (which is also not addressed in the current implementation). |
make docker-serve
Hi! Is it worth revisiting #340 considering we now have a Docker lesson in incubation? Running the webpage locally can still be a bit of a pain! I'd like to contribute a Dockerfile / docker-compose script / documentation as part of my instructor training checkout process.Edit: renamed issue after discussion below
The text was updated successfully, but these errors were encountered: