Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on libffi should be updated to 1.10 #79

Open
drawks opened this issue Oct 24, 2022 · 1 comment
Open

Dependency on libffi should be updated to 1.10 #79

drawks opened this issue Oct 24, 2022 · 1 comment

Comments

@drawks
Copy link

drawks commented Oct 24, 2022

Looking over the code I see that you use a third arg to ffi.gc in at least 1 place. This parameter to gc wasn't added until libffi 1.10. Either the code should check the version and conditionally set the size arg to gc calls OR the minimum version in setup.py should be updated.
@drawks
Copy link
Author

drawks commented Oct 24, 2022

c842858 Is where the updated cffi api is first used AFAICT and no other newer API calls are made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drawks