Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

App CSS get loaded inside carte-blanche #366

Open
FezVrasta opened this issue Jun 29, 2016 · 4 comments
Open

App CSS get loaded inside carte-blanche #366

FezVrasta opened this issue Jun 29, 2016 · 4 comments
Labels

Comments

@FezVrasta
Copy link
Contributor

FezVrasta commented Jun 29, 2016

I don't know if it's an expected behavior, but in my app.js I import some css files that are loaded in the global scope (styling for the HTML tags, body, etc).

When I open carte blanche and I visit the home page, everything is okay. When I open one of the components pages, the document.styl get loaded globally and changes the style of the whole Carte Blanche page.

To note that it doesn't happen with all the files I load, for example, only document.styl get loaded, even if I load at the exact same way even other two styl files.
I would expect those files to be loaded inside the iframes, not inside the top page.

I don't understand why this is happening tho.

@mxstbr mxstbr added the bug label Jun 29, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jun 29, 2016

That's definitely a bug, those styles shouldn't be injected into the main CarteBlanche. Do you have some sample code by chance? How are you importing the files?

@FezVrasta
Copy link
Contributor Author

I'm importing them with import './styles/document.styl

No code to show sorry :(

@mxstbr
Copy link
Contributor

mxstbr commented Jun 30, 2016

Alright, will try to replicate!

@nikgraf
Copy link
Member

nikgraf commented Jul 1, 2016

@FezVrasta how does your webpack config look like to load styl files?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants