Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gio endpoint doc & update definitions #15

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: add gio endpoint doc & update definitions #15

merged 2 commits into from
Apr 23, 2024

Conversation

alexmikhalevich
Copy link
Contributor

No description provided.

rollup.yaml Outdated Show resolved Hide resolved
rollup.yaml Outdated Show resolved Hide resolved
rollup.yaml Outdated Show resolved Hide resolved
Copy link

@diegonehab diegonehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

rollup.yaml Outdated Show resolved Hide resolved
rollup.yaml Outdated Show resolved Hide resolved
rollup.yaml Outdated Show resolved Hide resolved
diegonehab
diegonehab previously approved these changes Apr 23, 2024
@vfusco
Copy link
Contributor

vfusco commented Apr 23, 2024

please update the changelog as well.

@vfusco vfusco merged commit 71cbd20 into main Apr 23, 2024
1 check passed
@vfusco vfusco deleted the feature/gio branch April 23, 2024 17:24
@vfusco vfusco temporarily deployed to github-pages April 23, 2024 17:24 — with GitHub Pages Inactive
@@ -356,6 +398,12 @@ components:
example: "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
pattern: "^0x([0-9a-fA-F]{40})$"
format: address
value:
type: string
description: A big-endian 32-byte unsigned integer in hex.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this parameter deserved a better description.
It is the amount of Wei to be passed to the destination.
Most notably, it can be used for Ether withdrawals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants