Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Application owner #4

Closed
tuler opened this issue Sep 13, 2023 · 0 comments · Fixed by #5
Closed

Incorrect Application owner #4

tuler opened this issue Sep 13, 2023 · 0 comments · Fixed by #5
Assignees
Labels
Type: Bug Something isn't working

Comments

@tuler
Copy link
Member

tuler commented Sep 13, 2023

🙂 Expected behavior

Application owner should reflect the most up to date owner, because ownership can be transferred after application deployment.

🫠 Actual behavior

We are only setting the owner that was initially set.

🧪 Minimal test case

On mainnet: https://squid.subsquid.io/cartesi-rollups-mainnet/graphql

query MyQuery {
  applications {
    id
    owner
  }
}
{
  "data": {
    "applications": [
      {
        "id": "0x0974cc873df893b302f6be7ecf4f9d4b1a15c366",
        "owner": "0x0e28a8f88c6266df0fe274c15c1d4b27f8b373c0"
      }
    ]
  }
}

The correct owner is 0x0000000000000000000000000000000000000000

🌎 Environment

Ethereum mainnet

✔️ Possible solutions

If we really want to store the correct Application owner we need to track the OwnershipTransferred event of the CartesiDApp.

@tuler tuler added the Type: Bug Something isn't working label Sep 13, 2023
@brunomenezes brunomenezes self-assigned this Sep 14, 2023
@brunomenezes brunomenezes linked a pull request Sep 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants